From: Junio C Hamano <gitster@pobox.com>
To: Elia Pinto <gitter.spiros@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 6/6] attr.h: remove duplicate struct definition
Date: Mon, 14 Mar 2022 05:40:51 +0000 [thread overview]
Message-ID: <xmqqh781t7ks.fsf@gitster.g> (raw)
In-Reply-To: <20220314002327.243915-1-gitter.spiros@gmail.com> (Elia Pinto's message of "Mon, 14 Mar 2022 00:23:27 +0000")
Elia Pinto <gitter.spiros@gmail.com> writes:
> Subject: Re: [PATCH 6/6] attr.h: remove duplicate struct definition
I do not see other 5 from 1/6 thru 5/6 on the list.
If this is a leftover bit follow-up to the 5-patch series whose
cover letter was <20220313195536.224075-1-gitter.spiros@gmail.com>
we often see such a message
- with subject numbered as [PATCH 6/5]
- as follow-up to the same cover letter.
The patch text looks good, and we can see from the output of
$ git grep '^struct .*;' \*.h |
sort | uniq -c | sort -n | grep -v '^ *1 '
that this is the only duplicated opaque struct declaration in the
header files.
For now, I'd assume that is the case and queue it on the same topic
branch as the other five. Thanks.
> struct index_state is declared more than once.
>
> Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
> ---
> attr.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/attr.h b/attr.h
> index 3732505eda..3fb40cced0 100644
> --- a/attr.h
> +++ b/attr.h
> @@ -121,7 +121,6 @@ struct git_attr;
> /* opaque structures used internally for attribute collection */
> struct all_attrs_item;
> struct attr_stack;
> -struct index_state;
>
> /*
> * Given a string, return the gitattribute object that
next prev parent reply other threads:[~2022-03-14 5:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-14 0:23 [PATCH 6/6] attr.h: remove duplicate struct definition Elia Pinto
2022-03-14 5:40 ` Junio C Hamano [this message]
2022-03-14 10:39 ` Elia Pinto
2022-03-14 21:45 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh781t7ks.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitter.spiros@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).