git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Elijah Newren <newren@gmail.com>
Cc: "Git Mailing List" <git@vger.kernel.org>,
	"Jeff King" <peff@peff.net>, "Taylor Blau" <me@ttaylorr.com>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"Derrick Stolee" <dstolee@microsoft.com>,
	"Eric Sunshine" <sunshine@sunshineco.com>,
	"Phillip Wood" <phillip.wood123@gmail.com>
Subject: Re: en/keep-cwd
Date: Tue, 07 Dec 2021 10:26:18 -0800	[thread overview]
Message-ID: <xmqqh7bk8e5x.fsf@gitster.g> (raw)
In-Reply-To: <CABPp-BGdvOhy_g8vtRogqL2vPkZEtP4+N_5x0rhAWrX9x43WWA@mail.gmail.com> (Elijah Newren's message of "Mon, 6 Dec 2021 22:00:32 -0800")

Elijah Newren <newren@gmail.com> writes:

> On Mon, Dec 6, 2021 at 5:57 PM Junio C Hamano <gitster@pobox.com> wrote:
>>
>> * en/keep-cwd (2021-12-01) 11 commits
> ...
> If it helps, there are two parts to the review:
> - Do we want this feature?

I think we pretty much covered that we are for this behaviour
change.

> - Does this patch series implement the feature correctly?
>
> On the latter point, several folks provided useful suggestions.  I
> think I have addressed all their feedback so far, though no one has
> explicitly verified that.  Further review and/or acks to verify that I
> have indeed handled feedback to others' satisfaction would be welcome
> if anyone has the spare time.

Indeed.

Thanks.

  parent reply	other threads:[~2021-12-07 18:26 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-04  1:37 What's cooking in git.git (Dec 2021, #01; Fri, 3) Junio C Hamano
2021-12-06 19:13 ` Phillip Wood
2021-12-06 19:24   ` Junio C Hamano
2021-12-08 12:42   ` Johannes Schindelin
2021-12-09  1:02     ` Junio C Hamano
2021-12-09 10:39     ` Phillip Wood
2021-12-07  6:00 ` en/keep-cwd (Was: Re: What's cooking in git.git (Dec 2021, #01; Fri, 3)) Elijah Newren
2021-12-07  9:17   ` Ævar Arnfjörð Bjarmason
2021-12-07 20:33     ` Elijah Newren
2021-12-07 18:26   ` Junio C Hamano [this message]
2021-12-08 12:46   ` Johannes Schindelin
2021-12-07 15:54 ` What's cooking in git.git (Dec 2021, #01; Fri, 3) Derrick Stolee
2021-12-07 19:37 ` cf/fetch-set-upstream-while-detached (was: What's cooking in git.git (Dec 2021, #01; Fri, 3)) Ævar Arnfjörð Bjarmason
2021-12-07 20:41   ` cf/fetch-set-upstream-while-detached Junio C Hamano
2021-12-07 22:04     ` [PATCH v5] pull, fetch: fix segfault in --set-upstream option Ævar Arnfjörð Bjarmason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqh7bk8e5x.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=avarab@gmail.com \
    --cc=dstolee@microsoft.com \
    --cc=git@vger.kernel.org \
    --cc=me@ttaylorr.com \
    --cc=newren@gmail.com \
    --cc=peff@peff.net \
    --cc=phillip.wood123@gmail.com \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).