From: Junio C Hamano <gitster@pobox.com>
To: Derrick Stolee <stolee@gmail.com>
Cc: Matheus Tavares <matheus.bernardino@usp.br>,
git@vger.kernel.org, newren@gmail.com, vdye@github.com,
derrickstolee@github.com,
Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com>,
Sean Christopherson <seanjc@google.com>,
l.s.r@web.de
Subject: Re: [PATCH v3] add, rm, mv: fix bug that prevents the update of non-sparse dirs
Date: Thu, 28 Oct 2021 08:58:42 -0700 [thread overview]
Message-ID: <xmqqh7d1ta31.fsf@gitster.g> (raw)
In-Reply-To: <adb3e031-fe82-37ce-0967-a28aecb07035@gmail.com> (Derrick Stolee's message of "Thu, 28 Oct 2021 11:06:03 -0400")
Derrick Stolee <stolee@gmail.com> writes:
> On 10/28/2021 10:21 AM, Matheus Tavares wrote:
>
>> Since v2:
>> - Added comment about executing only one iteration on cone mode.
>> - Split for loop line for better readability.
>> - Stopped loop through "path" at first element to avoid an undefined
>> behavior.
>
> Thank you for these changes. I'm happy with this version.
Thanks, both. Will apply.
prev parent reply other threads:[~2021-10-28 15:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-25 21:07 [PATCH v2] add, rm, mv: fix bug that prevents the update of non-sparse dirs Matheus Tavares
2021-10-26 12:53 ` Derrick Stolee
2021-10-26 22:43 ` Matheus Tavares
2021-10-27 11:35 ` Derrick Stolee
2021-10-26 16:22 ` René Scharfe
2021-10-26 19:04 ` Derrick Stolee
2021-10-27 0:00 ` Matheus Tavares
2021-10-27 22:13 ` Chris Torek
2021-10-27 17:36 ` Sean Christopherson
2021-10-28 14:21 ` [PATCH v3] " Matheus Tavares
2021-10-28 15:06 ` Derrick Stolee
2021-10-28 15:58 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh7d1ta31.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=l.s.r@web.de \
--cc=matheus.bernardino@usp.br \
--cc=newren@gmail.com \
--cc=seanjc@google.com \
--cc=stolee@gmail.com \
--cc=vdye@github.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).