git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "USAMI Kenta via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, USAMI Kenta <tadsan@zonu.me>
Subject: Re: [PATCH] userdiff: support enum keyword in PHP hunk header
Date: Tue, 31 Aug 2021 12:15:32 -0700	[thread overview]
Message-ID: <xmqqh7f5toh7.fsf@gitster.g> (raw)
In-Reply-To: <pull.1082.git.git.1630389685997.gitgitgadget@gmail.com> (USAMI Kenta via GitGitGadget's message of "Tue, 31 Aug 2021 06:01:25 +0000")

"USAMI Kenta via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: USAMI Kenta <tadsan@zonu.me>
>
> "enum" keyword will be introduced in PHP 8.1.
> https://wiki.php.net/rfc/enumerations
>
> Signed-off-by: USAMI Kenta <tadsan@zonu.me>
> ---
>     userdiff: support enum keyword in PHP hunk header
>     
>     "enum" keyword will be introduced in PHP 8.1.
>     https://wiki.php.net/rfc/enumerations

I no longer speak PHP, but this looks sensible to me.

Thanks, will queue.

      reply	other threads:[~2021-08-31 19:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-31  6:01 [PATCH] userdiff: support enum keyword in PHP hunk header USAMI Kenta via GitGitGadget
2021-08-31 19:15 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqh7f5toh7.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=tadsan@zonu.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).