From: Junio C Hamano <gitster@pobox.com>
To: Aaron Schrab <aaron@schrab.com>
Cc: "David J. Malan via GitGitGadget" <gitgitgadget@gmail.com>,
git@vger.kernel.org, Elijah Newren <newren@gmail.com>,
"David J. Malan" <malan@harvard.edu>
Subject: Re: [PATCH] git-prompt: changes == to = for zsh's sake
Date: Mon, 20 Jul 2020 17:40:54 -0700 [thread overview]
Message-ID: <xmqqh7u18zu1.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200721002309.GA178512@pug.qqx.org> (Aaron Schrab's message of "Mon, 20 Jul 2020 20:23:09 -0400")
Aaron Schrab <aaron@schrab.com> writes:
> An alternate fix would be to switch to using double square brackets
> instead of single square brackets for the test. Since contents of
> double brackets have their own parsing rules the `equals` option
> doesn't apply there, and so `==` is available for checking equality
> same as in bash. IMHO, this provides saner behavior in general;
> although it's definitely not POSIX compliant.
It won't be but it does not have to be POSIX compliant anyway; after
all this is prompt support for bash with support for zsh added on
the side, neither is limited to strict POSIX.
I'd say that the patch posted is good as-is.
Thanks.
prev parent reply other threads:[~2020-07-21 0:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 23:17 [PATCH] git-prompt: changes == to = for zsh's sake David J. Malan via GitGitGadget
2020-07-20 23:58 ` Junio C Hamano
2020-07-21 0:40 ` Elijah Newren
2020-07-21 0:15 ` [PATCH v2] git-prompt: change " David J. Malan via GitGitGadget
2020-07-21 0:23 ` [PATCH] git-prompt: changes " Aaron Schrab
2020-07-21 0:40 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh7u18zu1.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=aaron@schrab.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=malan@harvard.edu \
--cc=newren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).