From: Junio C Hamano <gitster@pobox.com>
To: "Drew DeVault" <sir@cmpwn.com>
Cc: <git@vger.kernel.org>
Subject: Re: [PATCH] git-send-email: die if sendmail.* config is set
Date: Sat, 18 Jul 2020 13:10:26 -0700 [thread overview]
Message-ID: <xmqqh7u4bn4d.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <C49YLQZUZ4RG.129ZY8FQEYDYU@homura> (Drew DeVault's message of "Sat, 18 Jul 2020 14:25:41 -0400")
"Drew DeVault" <sir@cmpwn.com> writes:
> I originally had this just a warning, but it can be difficult to see.
> There's a lot of text printed from git send-email, a lot of it looks
> like diagnostics, and it can be easy to lose a message in there. And if
> you pass --annotate, which I encourage people to do, your editor
> immediately covers up the warning.
OK.
> I wonder if a happy medium would be adding a config option which
> squelches the message? If sendemail.squelchConfigError is set, for
> example.
I think with "squelches the message" replaced with "bypasses the
check", it would probably be a good idea. It may be that a
reasonable behaviour would be to check for any "sendemail.*" and
die, like your version does, by default, an optional opt-out
configuration variable (sendemail.forbidSendmailVariables) to
disable the check entirely, and then add a hint that mentions the
variable to the "die" message in your patch.
prev parent reply other threads:[~2020-07-18 20:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-18 13:23 [PATCH] git-send-email: die if sendmail.* config is set Drew DeVault
2020-07-18 18:02 ` Junio C Hamano
2020-07-18 18:25 ` Drew DeVault
2020-07-18 20:10 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh7u4bn4d.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=sir@cmpwn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox