From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28842C433E0 for ; Wed, 20 May 2020 03:19:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DC0B0204EF for ; Wed, 20 May 2020 03:19:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=pobox.com header.i=@pobox.com header.b="IlQ4Tesy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728409AbgETDTk (ORCPT ); Tue, 19 May 2020 23:19:40 -0400 Received: from pb-smtp1.pobox.com ([64.147.108.70]:56446 "EHLO pb-smtp1.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726379AbgETDTj (ORCPT ); Tue, 19 May 2020 23:19:39 -0400 Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 19DB559053; Tue, 19 May 2020 23:19:37 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=3SVszCAHSVtwVbXreU7mtf16od4=; b=IlQ4Te syWtE00+yRJX7/VHXIH5eYB+DC1D4JCRV2NtYzqJHs+/+Ghivn9C9A3SRixSM8Bm XkHV/ddQBb5Sf35J7IkaMvc21Ny+7XYK3GISCnbs2eXD1o4FneVVWG8JRvzY5MxO 4TQcgB3HBCQegbSz/K6rzxLzaUwAzPQmsvGhY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=IkPe2/UrjhkgFJafCg1ZQ9ifc4NDZHEJ Sl3kM8VCCbT7uP5DAZofb3sU6sQ/dzjHVGlmpwg6cKJdKf78ZoCswdTge5np7V2v qBOldHcYUEBY9c0Vsd/9+CAz17XM9hge9FebajISBS966goGEAS040lGCVoiaxDQ VRfICplX9cQ= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 114BB59052; Tue, 19 May 2020 23:19:37 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [35.196.173.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 8CB3659051; Tue, 19 May 2020 23:19:36 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: Darren Tucker Cc: git@vger.kernel.org Subject: Re: [PATCH 6/7] Check if strtoumax is a macro (eg HP-UX 11.11). References: <20200518100356.29292-1-dtucker@dtucker.net> <20200518100356.29292-6-dtucker@dtucker.net> Date: Tue, 19 May 2020 20:19:36 -0700 In-Reply-To: (Darren Tucker's message of "Wed, 20 May 2020 11:49:09 +1000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: BBB7EC80-9A48-11EA-9EE2-C28CBED8090B-77302942!pb-smtp1.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Darren Tucker writes: > The caveat with putting it in GIT_CHECK_FUNC() is that you'll need to > include the union of all of the header files that might have all of > the things you're looking for instead of the hopefully small set of > them that might have the one specific thing you're looking for. I > suspect that would be more hassle than it's worth. Oh, what I had in mind was to replace GIT_CHECK_FUNC() with a macro that takes not just function name but also include file. Not "the union of all the include files".