From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Emily Shaffer <emilyshaffer@google.com>, git@vger.kernel.org
Subject: Re: [PATCH v2] bugreport: collect list of populated hooks
Date: Mon, 27 Apr 2020 17:04:10 -0700 [thread overview]
Message-ID: <xmqqh7x45vd1.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200427234510.GC36078@google.com> (Jonathan Nieder's message of "Mon, 27 Apr 2020 16:45:10 -0700")
Jonathan Nieder <jrnieder@gmail.com> writes:
> Emily Shaffer wrote:
>
>> --- a/t/t0091-bugreport.sh
>> +++ b/t/t0091-bugreport.sh
>> @@ -57,5 +57,15 @@ test_expect_success 'can create leading directories outside of a git dir' '
>> nongit git bugreport -o foo/bar/baz
>> '
>>
>> +test_expect_success 'indicates populated hooks' '
>> + test_when_finished rm git-bugreport-hooks.txt &&
>> + test_when_finished rm -fr .git/hooks &&
>> + mkdir .git/hooks &&
>> + touch .git/hooks/applypatch-msg &&
>> + chmod +x .git/hooks/applypatch-msg &&
>
> optional: could use write_script for this
Yup, it is a good practice to do so. Use of touch is especially bad
here, as it is quite plausible for us to later change the "is the
hook there?" check to exclude a completely empty file.
>> + git bugreport -s hooks &&
>> + test_i18ngrep applypatch-msg git-bugreport-hooks.txt
>
> This should work even when translated, so it can use "grep" instead of
> test_i18ngrep.
Nicely spotted.
Thanks.
next prev parent reply other threads:[~2020-04-28 0:04 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 23:38 [PATCH] bugreport: collect list of populated hooks Emily Shaffer
2020-04-25 0:30 ` Jonathan Nieder
2020-04-27 20:48 ` [PATCH] bugreport: drop time.h include Emily Shaffer
2020-04-27 21:03 ` Jonathan Nieder
2020-04-27 21:25 ` Junio C Hamano
2020-04-27 21:41 ` Junio C Hamano
2020-04-27 21:56 ` Emily Shaffer
2020-04-27 23:27 ` Junio C Hamano
2020-04-27 23:42 ` [PATCH v2] bugreport: drop extraneous includes Emily Shaffer
2020-04-27 23:46 ` Jonathan Nieder
2020-04-25 4:52 ` [PATCH] bugreport: collect list of populated hooks Junio C Hamano
2020-04-27 19:02 ` Emily Shaffer
2020-04-27 20:46 ` Junio C Hamano
2020-04-27 20:49 ` Emily Shaffer
2020-04-27 23:38 ` [PATCH v2] " Emily Shaffer
2020-04-27 23:45 ` Jonathan Nieder
2020-04-28 0:04 ` Junio C Hamano [this message]
2020-04-30 0:01 ` Emily Shaffer
2020-04-30 1:24 ` [PATCH v3] " Emily Shaffer
2020-04-30 1:50 ` Jonathan Nieder
2020-04-30 1:53 ` Jonathan Nieder
2020-04-30 17:44 ` Junio C Hamano
2020-04-30 22:09 ` Junio C Hamano
2020-05-07 21:08 ` Emily Shaffer
2020-05-07 23:06 ` Junio C Hamano
2020-05-11 21:26 ` Emily Shaffer
2020-05-08 0:53 ` [PATCH v4] " Emily Shaffer
2020-05-08 1:20 ` Junio C Hamano
2020-05-08 1:34 ` Đoàn Trần Công Danh
2020-05-11 21:22 ` Emily Shaffer
2020-05-11 22:14 ` [PATCH v5] " Emily Shaffer
2020-05-11 23:26 ` Jonathan Nieder
2020-05-11 23:45 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh7x45vd1.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=emilyshaffer@google.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).