From: Junio C Hamano <gitster@pobox.com>
To: Kevin Willford <kewillf@microsoft.com>
Cc: "git\@vger.kernel.org" <git@vger.kernel.org>,
"peff\@peff.net" <peff@peff.net>,
"pclouds\@gmail.com" <pclouds@gmail.com>
Subject: Re: [PATCH 1/1] reset: fix reset when using the sparse-checkout feature.
Date: Mon, 11 Sep 2017 13:01:39 +0900 [thread overview]
Message-ID: <xmqqh8w951ek.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <SN1PR21MB00140C84DC02F3491F4E8469B76A0@SN1PR21MB0014.namprd21.prod.outlook.com> (Kevin Willford's message of "Sat, 9 Sep 2017 04:54:31 +0000")
Kevin Willford <kewillf@microsoft.com> writes:
> I agree with this when you are not dealing with a sparse-checkout.
> When using a sparse-checkout I expect git not to touch things
> outside of what I have specified in my sparse-checkout file. If it
> does, it should let me know or put my working directory in a
> state that is expected. Especially when it is changing the
> skip-worktree bits causing files outside the sparse-checkout to be
> reported incorrectly by status.
Well, whether using a sparse-checkout or not, I would expect Git not
to touch *any* filesystem entity when "git reset" (not "--hard",
just "git reset [<tree-ish>]") is given, whether the path is inside
or outside the sparse-checkout area.
Stepping back a bit, I am not sure if it is sane or even valid for
the end-user to modify paths outside sparse-checkout area, but that
is probably a separate tangent.
next prev parent reply other threads:[~2017-09-11 4:01 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-08 18:00 [PATCH 0/1] reset: fix mixed reset when using sparse-checkout Kevin Willford
2017-09-08 18:00 ` [PATCH 1/1] reset: fix reset when using the sparse-checkout feature Kevin Willford
2017-09-08 18:54 ` Torsten Bögershausen
2017-09-08 19:04 ` Junio C Hamano
2017-09-08 19:01 ` Junio C Hamano
2017-09-08 20:08 ` Kevin Willford
2017-09-08 19:12 ` Junio C Hamano
2017-09-08 20:02 ` Kevin Willford
2017-09-09 3:18 ` Junio C Hamano
2017-09-09 4:54 ` Kevin Willford
2017-09-11 4:01 ` Junio C Hamano [this message]
2017-09-11 11:15 ` Johannes Schindelin
2017-09-12 3:56 ` Junio C Hamano
2017-09-12 20:20 ` Kevin Willford
2017-09-12 22:29 ` Jacob Keller
2017-09-12 23:30 ` Kevin Willford
2017-09-13 1:39 ` Jacob Keller
2017-09-13 17:09 ` Kevin Willford
2017-09-13 22:17 ` Junio C Hamano
2017-09-14 14:26 ` Kevin Willford
2017-09-15 5:00 ` Junio C Hamano
2017-09-15 17:21 ` Kevin Willford
2017-09-15 21:33 ` Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh8w951ek.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=kewillf@microsoft.com \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox