From: Junio C Hamano <gitster@pobox.com>
To: Emily Xie <emilyxxie@gmail.com>
Cc: git@vger.kernel.org, David Turner <novalis@novalis.org>
Subject: Re: [PATCH] pathspec: warn on empty strings as pathspec
Date: Wed, 22 Jun 2016 23:17:12 -0700 [thread overview]
Message-ID: <xmqqh9ckjuon.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CAAin2AQR3yP7X=NLQ=9+0QGJZMCN7=xbpZ=H7r56RvvBfLJSEg@mail.gmail.com> (Emily Xie's message of "Wed, 22 Jun 2016 19:48:47 -0400")
Emily Xie <emilyxxie@gmail.com> writes:
> Awesome. Thanks, Junio---this is exciting!
No, thank _you_.
> As for step 2: do you have a good sense on the timing? Around how long
> should I wait to submit the patch for it?
Not so fast. We'll wait for others to comment first.
I am queuing this change but that does not mean anything more than
that I am not outright rejecting the idea.
It is possible that others may assess the cost of having to do the
two-step migration differently, and the list concensus may end up
being "if it hurts, don't pass an empty string", i.e. we'd better
without this patch or subsequent second step. If that happens, the
first step dies without hitting 'next'. I'd say we'd wait at least
for a week.
Otherwise, if the change is received favourably, we'll merge it to
'next', do the same waiting for comments. Repeat the same and then
merge to 'master'. After it hits the next feature release (probably
at around the end of August), the change will be seen by wider
general public, and at that point we may see strong opposition from
them with a good argument neither of us thought of why we shouldn't
do this change, in which case we might have to revise the plan and
scrap the whole thing.
So, we'll wait and see.
next prev parent reply other threads:[~2016-06-23 6:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-22 23:00 [PATCH] pathspec: warn on empty strings as pathspec Emily Xie
2016-06-22 23:12 ` Junio C Hamano
2016-06-22 23:48 ` Emily Xie
2016-06-23 6:17 ` Junio C Hamano [this message]
2016-06-24 18:21 ` Emily Xie
-- strict thread matches above, loose matches on Subject: below --
2016-06-21 2:15 Emily Xie
2016-06-21 5:11 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh9ckjuon.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=emilyxxie@gmail.com \
--cc=git@vger.kernel.org \
--cc=novalis@novalis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox