Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Okhuomon Ajayi <okhuomonajayi54@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] doc: wrap emailed text near 70 columns
Date: Thu, 19 Nov 2026 14:20:32 -0800	[thread overview]
Message-ID: <xmqqik1sv4y7.fsf@gitster.g> (raw)
In-Reply-To: <20261119105300.95746-1-okhuomonajayi54@gmail.com> (Okhuomon Ajayi's message of "Thu, 19 Nov 2026 11:53:00 +0100")

Okhuomon Ajayi <okhuomonajayi54@gmail.com> writes:

> CodingGuidelines, SubmittingPatches, and ReviewingGuidelines do
> not say how long an emailed line should be. State the limit in
> each: keep the text near 70 columns so it still fits on an
> 80-column terminal after a few levels of quoting.

Thanks, but then why not also suggest to use these inter-paragraph
blank lines?

>
> Signed-off-by: Okhuomon Ajayi <okhuomonajayi54@gmail.com>
> ---
>  Documentation/CodingGuidelines         | 4 ++++
>  Documentation/ReviewingGuidelines.adoc | 3 +++
>  Documentation/SubmittingPatches        | 4 ++++
>  3 files changed, 11 insertions(+)
>
> diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines
> index 23a4d2186a..a0cc5a050d 100644
> --- a/Documentation/CodingGuidelines
> +++ b/Documentation/CodingGuidelines
> @@ -33,6 +33,10 @@ Git in general, a few rough rules are:
>     achieve and why the changes were necessary (more on this in the
>     accompanying SubmittingPatches document).
>  
> + - E-mailed text, including a patch message and a review reply, is
> +   kept near 70 columns, so it still fits on an 80-column terminal
> +   after being quoted a few times.
> +
>   - A label "NEEDSWORK:" followed by a description of the things to
>     be done is a way to leave in-code comments to document design
>     decisions yet to be made. 80% of the work to resolve a NEEDSWORK
> diff --git a/Documentation/ReviewingGuidelines.adoc b/Documentation/ReviewingGuidelines.adoc
> index 6534643cff..8770f0597c 100644
> --- a/Documentation/ReviewingGuidelines.adoc
> +++ b/Documentation/ReviewingGuidelines.adoc
> @@ -116,6 +116,9 @@ guidance, and concrete tips for interacting with patches on the mailing list.
>    unrelated to your review from the email reply. Make sure to leave enough
>    context for readers to understand your comments!
>  
> +- Wrap a review reply so it still fits on an 80-column terminal after
> +  being quoted a few times. Around 70 columns is a comfortable limit.
> +
>  - If you cannot complete a full review of a series all at once, consider letting
>    the author know (on- or off-list) if/when you plan to review the rest of the
>    series.
> diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
> index c60855f706..2525cc7e20 100644
> --- a/Documentation/SubmittingPatches
> +++ b/Documentation/SubmittingPatches
> @@ -700,6 +700,10 @@ WARNING: Be wary of your MUAs word-wrap
>  corrupting your patch.  Do not cut-n-paste your patch; you can
>  lose tabs that way if you are not careful.
>  
> +Wrap the prose you send so it still fits on an 80-column terminal
> +after being quoted a few times.  Around 70 columns is a comfortable
> +limit.
> +
>  It is a common convention to prefix your subject line with
>  [PATCH].  This lets people easily distinguish patches from other
>  e-mail discussions.  Use of markers in addition to PATCH within
>
> base-commit: 7fb6055e678f800320d8ab8cd8f201d9493d1ba0

  reply	other threads:[~2026-11-19 22:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 10:53 [PATCH] doc: wrap emailed text near 70 columns Okhuomon Ajayi
2026-11-19 22:20 ` Junio C Hamano [this message]
2026-11-19 22:26   ` Okhuomon Ajayi
2026-11-20  5:59 ` [PATCH v2] " Okhuomon Ajayi
2026-11-20 10:07   ` Andy Koppe
2026-11-20 10:26     ` Okhuomon Ajayi
2026-11-20 11:02   ` [PATCH v3] doc: wrap emailed text to a maximum of 72 columns Okhuomon Ajayi
2026-11-20 17:58     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqik1sv4y7.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=okhuomonajayi54@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox