From: Junio C Hamano <gitster@pobox.com>
To: Karthik Nayak <karthik.188@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 00/20] t9300: group and move tests to other files
Date: Tue, 10 Nov 2026 08:45:26 -0800 [thread overview]
Message-ID: <xmqqik24tz2x.fsf@gitster.g> (raw)
In-Reply-To: <20261110-kn-fast-import-tests-1-v1-0-dbd9ee502aae@gmail.com> (Karthik Nayak's message of "Tue, 10 Nov 2026 12:49:45 +0100")
Karthik Nayak <karthik.188@gmail.com> writes:
> While reading the git-fast-import(1) code, I stumbled upon t9300. The
> test file is around 4000 LoC and each test has some dependency on the
> state setup by previous tests.
>
> This long series unwinds some of these tests and moves them into
> new/existing tests based on what they exercise. This leaves t9300 in a
> better state. I think we can do more here, but I decided to stop before
> this series got even longer. Based on the reception of this series, I
> will follow up with more cleanups.
Wow, cleaning up this script is long overdue. Thanks for tackling it.
next prev parent reply other threads:[~2026-11-10 16:45 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 11:49 [PATCH 00/20] t9300: group and move tests to other files Karthik Nayak
2026-11-10 11:49 ` [PATCH 01/20] t9300: move 'fastimport.unpackLimit' to the required test Karthik Nayak
2026-11-10 11:49 ` [PATCH 02/20] t9300: make the series B tests self-contained Karthik Nayak
2026-11-10 11:49 ` [PATCH 03/20] t9300: make the series T " Karthik Nayak
2026-11-10 11:49 ` [PATCH 04/20] t9300: make the series S " Karthik Nayak
2026-11-10 11:49 ` [PATCH 05/20] t9300: make the series V " Karthik Nayak
2026-11-10 11:49 ` [PATCH 06/20] t9300: make the series Q " Karthik Nayak
2026-11-10 11:49 ` [PATCH 07/20] t9300: make the series P " Karthik Nayak
2026-11-10 11:49 ` [PATCH 08/20] t9300: make the series O " Karthik Nayak
2026-11-10 11:49 ` [PATCH 09/20] t9300: make the big blob " Karthik Nayak
2026-11-10 11:49 ` [PATCH 10/20] t9300: make the ref update " Karthik Nayak
2026-11-10 11:49 ` [PATCH 11/20] t9300: make the date format " Karthik Nayak
2026-11-10 11:49 ` [PATCH 12/20] t9300: make the pack edges test self-contained Karthik Nayak
2026-11-10 11:49 ` [PATCH 13/20] t9300: make the marks tests self-contained Karthik Nayak
2026-11-10 11:49 ` [PATCH 14/20] t9300: make the series Y " Karthik Nayak
2026-11-10 11:50 ` [PATCH 15/20] t9300: make the cat-blob " Karthik Nayak
2026-11-10 11:50 ` [PATCH 16/20] t9300: make the feature and option " Karthik Nayak
2026-11-10 11:50 ` [PATCH 17/20] t9300: make the stream " Karthik Nayak
2026-11-10 11:50 ` [PATCH 18/20] t9300: make the get-mark and encoding " Karthik Nayak
2026-11-10 11:50 ` [PATCH 19/20] t9300: move self-contained tests into dedicated files Karthik Nayak
2026-11-10 11:50 ` [PATCH 20/20] t93xx: drop the series letter from the moved test names Karthik Nayak
2026-11-10 16:45 ` Junio C Hamano [this message]
2026-11-10 20:06 ` [PATCH 00/20] t9300: group and move tests to other files Junio C Hamano
2026-11-11 11:22 ` Karthik Nayak
2026-11-12 17:34 ` [PATCH v2 " Karthik Nayak
2026-11-12 17:34 ` [PATCH v2 01/20] t9300: move 'fastimport.unpackLimit' to the required test Karthik Nayak
2026-11-12 17:34 ` [PATCH v2 02/20] t9300: make the series B tests self-contained Karthik Nayak
2026-11-12 17:34 ` [PATCH v2 03/20] t9300: make the series T " Karthik Nayak
2026-11-12 17:34 ` [PATCH v2 04/20] t9300: make the series S " Karthik Nayak
2026-11-12 17:34 ` [PATCH v2 05/20] t9300: make the series V " Karthik Nayak
2026-11-12 17:34 ` [PATCH v2 06/20] t9300: make the series Q " Karthik Nayak
2026-11-12 17:34 ` [PATCH v2 07/20] t9300: make the series P " Karthik Nayak
2026-11-12 17:34 ` [PATCH v2 08/20] t9300: make the series O " Karthik Nayak
2026-11-12 17:34 ` [PATCH v2 09/20] t9300: make the big blob " Karthik Nayak
2026-11-12 17:34 ` [PATCH v2 10/20] t9300: make the ref update " Karthik Nayak
2026-11-12 17:34 ` [PATCH v2 11/20] t9300: make the date format " Karthik Nayak
2026-11-12 17:34 ` [PATCH v2 12/20] t9300: make the pack edges test self-contained Karthik Nayak
2026-11-12 17:34 ` [PATCH v2 13/20] t9300: make the marks tests self-contained Karthik Nayak
2026-11-12 17:34 ` [PATCH v2 14/20] t9300: make the series Y " Karthik Nayak
2026-11-12 17:34 ` [PATCH v2 15/20] t9300: make the cat-blob " Karthik Nayak
2026-11-12 17:34 ` [PATCH v2 16/20] t9300: make the feature and option " Karthik Nayak
2026-11-12 17:34 ` [PATCH v2 17/20] t9300: make the stream " Karthik Nayak
2026-11-12 17:34 ` [PATCH v2 18/20] t9300: make the get-mark and encoding " Karthik Nayak
2026-11-12 17:34 ` [PATCH v2 19/20] t9300: move self-contained tests into dedicated files Karthik Nayak
2026-11-12 17:34 ` [PATCH v2 20/20] t93xx: drop the series letter from the moved test names Karthik Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqik24tz2x.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=karthik.188@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox