From: Junio C Hamano <gitster@pobox.com>
To: Farid Zakaria <farid.m.zakaria@gmail.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
Patrick Steinhardt <ps@pks.im>,
M Hickford <mirth.hickford@gmail.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Jeff Hostetler <jeffhostetler@github.com>
Subject: Re: [PATCH v2 0/3] credential-cache: fix two races when daemons start at once
Date: Wed, 04 Nov 2026 23:39:11 -0800 [thread overview]
Message-ID: <xmqqik2bybfk.fsf@gitster.g> (raw)
In-Reply-To: <20261104-fz-credential-cache-race-v2-0-ddccd0831eba@gmail.com> (Farid Zakaria's message of "Wed, 04 Nov 2026 11:53:13 -0800")
Farid Zakaria <farid.m.zakaria@gmail.com> writes:
> - Not changed: the socket is still removed at exit through the
> tempfile API, which unlinks it without the unix_ss_was_stolen().
> There was a discussion with Junio about this. I can do that if it's
> a requirement in a V3.
Sorry, but I do not recall having any discussion on this.
I just pointed out a potential problem, and you sent this version
out without responding to my review, so I cannot tell why you
thought it was OK not to address it. Which means I cannot answer
"if it's a requirement" question.
Perhaps you had a solid technical reason why the "stolen" detection
is not necessary, in which case it might be OK. Perhaps you were
too lazy to think the issue through, in which case it might not be
OK. Or there was some other reason why you thought it is OK not to
address the issue.
prev parent reply other threads:[~2026-11-05 7:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-01 23:29 [PATCH 0/2] credential-cache: fix two races when daemons start at once Farid Zakaria
2026-11-01 23:29 ` [PATCH 1/2] credential-cache--daemon: allow a concurrently created socket dir Farid Zakaria
2026-11-03 8:01 ` Patrick Steinhardt
2026-11-04 18:25 ` Farid Zakaria
2026-11-04 2:58 ` Jeff King
2026-11-01 23:29 ` [PATCH 2/2] credential-cache--daemon: do not take over a running daemon's socket Farid Zakaria
2026-11-03 8:01 ` Patrick Steinhardt
2026-11-04 18:28 ` Farid Zakaria
2026-11-03 17:24 ` Junio C Hamano
2026-11-04 3:07 ` Jeff King
2026-11-04 19:53 ` [PATCH v2 0/3] credential-cache: fix two races when daemons start at once Farid Zakaria
2026-11-04 19:53 ` [PATCH v2 1/3] credential-cache--daemon: do not apply core.sharedRepository Farid Zakaria
2026-11-04 19:53 ` [PATCH v2 2/3] credential-cache--daemon: allow a concurrently created socket dir Farid Zakaria
2026-11-04 19:53 ` [PATCH v2 3/3] credential-cache--daemon: do not take over a running daemon's socket Farid Zakaria
2026-11-05 7:39 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqik2bybfk.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=farid.m.zakaria@gmail.com \
--cc=git@vger.kernel.org \
--cc=jeffhostetler@github.com \
--cc=mirth.hickford@gmail.com \
--cc=peff@peff.net \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox