From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: Andy Koppe <andy.koppe@gmail.com>,
git@vger.kernel.org, Karthik Nayak <karthik.188@gmail.com>
Subject: Re: [PATCH v3] refs/files: keep root refs out of loose ref cache
Date: Tue, 20 Oct 2026 19:27:37 -0700 [thread overview]
Message-ID: <xmqqik2vss86.fsf@gitster.g> (raw)
In-Reply-To: <atcNOMxaz2WxDIA1@pks.im> (Patrick Steinhardt's message of "Tue, 20 Oct 2026 08:42:00 +0200")
Patrick Steinhardt <ps@pks.im> writes:
>> Changes from v2:
>> - Drop fixes to documentation of REFS_FOR_EACH_INCLUDE_ROOT_REFS and
>> --include-root-refs added in v2. I'll create a separate patch with
>> those as well as other fixes for outdated uses of "pseudoref".
>>
>> The range diff shows the changes from v1, because they're of more
>> interest than dropping the documentation changes I'd added in v2.
>
> Thanks for this. By the way, I would recommend to have a look at b4,
> which handles all of the bookkeeping for you.
Perhaps it cuts both ways. Can you tell b4 to do the flexible thing
the author did in this case?
> In any case, this patch looks good to me. Thanks!
Thanks for writing and reviewing. Let me mark the topic for 'next'.
next prev parent reply other threads:[~2026-10-21 2:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-14 15:32 [PATCH] refs/files: keep root refs out of loose ref cache Andy Koppe
2026-10-15 5:58 ` Patrick Steinhardt
2026-10-15 17:31 ` Junio C Hamano
2026-10-15 19:43 ` Andy Koppe
2026-10-16 7:00 ` Patrick Steinhardt
2026-10-16 15:05 ` Junio C Hamano
2026-10-17 20:04 ` [PATCH v2] " Andy Koppe
2026-10-19 5:57 ` Patrick Steinhardt
2026-10-19 21:30 ` Andy Koppe
2026-10-19 20:34 ` [PATCH v3] " Andy Koppe
2026-10-20 6:42 ` Patrick Steinhardt
2026-10-21 2:27 ` Junio C Hamano [this message]
2026-10-21 5:36 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqik2vss86.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=andy.koppe@gmail.com \
--cc=git@vger.kernel.org \
--cc=karthik.188@gmail.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox