From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org, Karthik Nayak <karthik.188@gmail.com>
Subject: Re: [PATCH] gitlab-ci: fix "check" jobs with large merge requests
Date: Mon, 19 Oct 2026 13:09:49 -0700 [thread overview]
Message-ID: <xmqqik2x4fle.fsf@gitster.g> (raw)
In-Reply-To: <atW_BmTQhxFRLc0a@pks.im> (Patrick Steinhardt's message of "Mon, 19 Oct 2026 08:56:06 +0200")
Patrick Steinhardt <ps@pks.im> writes:
> I tend to ignore those myself:
>
> - "check-style" is not all that useful as we don't fully submit us to
> clang-format's style, so whatever it generates is not authoritative
> anyway.
>
> - "check-whitespace" was quite useless to me because it breaks rather
> frequently.
>
> I still think that "check-style" _could_ be useful, but only if we fully
> commit to clang-format. It would remove a whole class of nitpicks
> and thus reduce the burden on both newcomers and reviewers. But that's a
> discussion I don't really want to lead :)
Hmph, I haven't seen check-whitespace giving useless false positive
myself. I tend to agree that check-style would not be useful as it
came fairly late to the project after all the code have been written
long ago.
next prev parent reply other threads:[~2026-10-19 20:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-16 14:48 [PATCH] gitlab-ci: fix "check" jobs with large merge requests Patrick Steinhardt
2026-10-16 17:15 ` Junio C Hamano
2026-10-19 6:56 ` Patrick Steinhardt
2026-10-19 18:51 ` Karthik Nayak
2026-10-19 20:09 ` Junio C Hamano [this message]
2026-10-20 5:58 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqik2x4fle.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=karthik.188@gmail.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox