Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Cc: "brian m. carlson" <sandals@crustytoothpaste.net>,
	Phillip Wood <phillip.wood123@gmail.com>,
	Andreas Schwab <schwab@linux-m68k.org>,
	Ondrej Pohorelsky <opohorel@redhat.com>,
	Patrick Steinhardt <ps@pks.im>, Jeff King <peff@peff.net>,
	"D. Ben Knoble" <ben.knoble@gmail.com>,
	Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: What's cooking in git.git (May 2026, #02)
Date: Mon, 11 May 2026 14:51:53 +0900	[thread overview]
Message-ID: <xmqqik8usdc6.fsf@gitster.g> (raw)
In-Reply-To: <xmqq4iketzh0.fsf@gitster.g> (Junio C. Hamano's message of "Mon, 11 May 2026 12:08:27 +0900")

Junio C Hamano <gitster@pobox.com> writes:

[cc: list taken from <pull.1853.v4.git.1770113882.gitgitgadget@gmail.com>]

> * jc/neuter-sideband-fixup (2026-03-05) 6 commits
>   (merged to 'next' on 2026-03-13 at 5a4098b0cd)
>  + sideband: drop 'default' configuration
>  + sideband: offer to configure sanitizing on a per-URL basis
>  + sideband: add options to allow more control sequences to be passed through
>  + sideband: do allow ANSI color sequences by default
>  + sideband: introduce an "escape hatch" to allow control characters
>  + sideband: mask control characters
>  (this branch is used by jc/neuter-sideband-post-3.0.)
>
>  Try to resurrect and reboot a stalled "avoid sending risky escape
>  sequences taken from sideband to the terminal" topic by Dscho.  The
>  plan is to keep it in 'next' long enough to see if anybody screams
>  with the "everything dropped except for ANSI color escape sequences"
>  default.

This topic has cooked sufficiently long in 'next'.  I'd push it to
'master' so that it now would have enough exposure time before the
next release.

But I'd do so with a bit of twist.

I plan to hold off the final step.  That step allows to pass
anything until Git 3.0.  That way, those who work with the version
in 'master' will see how things would look like with these strict
checks that allowlist only a few types of selected control sequences
by default.  With luck, we might not hear any complaints from
anybody, in which case we may not have to apply the last step at all.

Of course, if there are huge complaints, then we may have to
reconsider the approach to allow only the selected sequences and
instead blacklist known bad/risky sequences.  In such a case, we may
have to revert the merge first before we regroup, but it is more
than likely that we won't have to do so---after all, the topic
(without the final "loosen rules for now" step) has been used by
those who are on 'next' for quite a while already.  Knock wood...

  reply	other threads:[~2026-05-11  5:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-11  3:08 What's cooking in git.git (May 2026, #02) Junio C Hamano
2026-05-11  5:51 ` Junio C Hamano [this message]
2026-05-11 13:22 ` kh/name-rev-custom-format Kristoffer Haugsbakk
2026-05-12  0:56 ` What's cooking in git.git (May 2026, #02) Taylor Blau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqik8usdc6.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=ben.knoble@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=johannes.schindelin@gmx.de \
    --cc=opohorel@redhat.com \
    --cc=peff@peff.net \
    --cc=phillip.wood123@gmail.com \
    --cc=ps@pks.im \
    --cc=sandals@crustytoothpaste.net \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox