From: Junio C Hamano <gitster@pobox.com>
To: Johannes Sixt <j6t@kdbg.org>
Cc: Wolfgang Faust <contrib-git@wolfgangfaust.com>,
Birger Skogeng Pedersen <birger.sp@gmail.com>,
Pratyush Yadav <me@yadavpratyush.com>,
Marc Branchaud <marcnarc@xiplink.com>,
git@vger.kernel.org
Subject: Re: [PATCH 0/4] run auto maintenance in git-gui
Date: Sat, 07 Mar 2026 22:02:55 -0800 [thread overview]
Message-ID: <xmqqikb6uacw.fsf@gitster.g> (raw)
In-Reply-To: <40ccd060-e6f7-4130-a25e-3c2f65df8eb7@kdbg.org> (Johannes Sixt's message of "Sat, 7 Mar 2026 23:37:56 +0100")
Johannes Sixt <j6t@kdbg.org> writes:
> The option does not only control whether or not a warning appears, but
> also whether garbage collection happens or not. When it is set to false,
> then in addition to squelching the warning, garbage collection does
> *not* happen.
Ah, OK, now what you said makes perfect sense.
> I think so, too. For this reason, my implied suggestion was to protect
> the new call of `git maintenance` with a check whether gui.gcwarning is
> enabled. Then we don't make anything worse for those who have it disabled.
Good.
Thanks.
next prev parent reply other threads:[~2026-03-08 6:02 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-26 17:31 git-gui: disable the "loose objects popup" dialog? Birger Skogeng Pedersen
2019-09-26 18:54 ` Johannes Sixt
2019-09-26 19:13 ` Birger Skogeng Pedersen
2019-09-26 19:15 ` Pratyush Yadav
2019-09-26 21:12 ` Birger Skogeng Pedersen
2019-09-26 21:13 ` Johannes Sixt
2019-10-01 18:00 ` Pratyush Yadav
2019-10-02 7:12 ` Birger Skogeng Pedersen
2019-10-02 18:48 ` Johannes Sixt
2026-03-06 5:15 ` [PATCH 0/4] run auto maintenance in git-gui Wolfgang Faust
2026-03-06 5:26 ` [PATCH 1/4] git-gui: run auto maintenance on commit Wolfgang Faust
2026-03-06 5:30 ` [PATCH 2/4] git-gui: remove hint_gc dialog Wolfgang Faust
2026-03-06 5:32 ` [PATCH 3/4] git-gui: remove "Compress Database" feature Wolfgang Faust
2026-03-06 5:32 ` [PATCH 4/4] scalar: remove obsolete gui.GCWarning setting Wolfgang Faust
2026-03-07 11:32 ` [PATCH 0/4] run auto maintenance in git-gui Johannes Sixt
2026-03-07 22:01 ` Junio C Hamano
2026-03-07 22:37 ` Johannes Sixt
2026-03-08 6:02 ` Junio C Hamano [this message]
2026-03-11 4:48 ` Wolfgang Faust
2026-03-13 12:38 ` Johannes Sixt
2019-10-02 20:41 ` git-gui: disable the "loose objects popup" dialog? Marc Branchaud
2019-09-26 21:14 ` Marc Branchaud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqikb6uacw.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=birger.sp@gmail.com \
--cc=contrib-git@wolfgangfaust.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=marcnarc@xiplink.com \
--cc=me@yadavpratyush.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox