* [PATCH v4] doc: clarify server behavior for invalid 'want' lines in HTTP protocol
@ 2025-11-05 14:38 Queen Ediri Jessa
2025-11-06 17:46 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: Queen Ediri Jessa @ 2025-11-05 14:38 UTC (permalink / raw)
To: git; +Cc: gitster, christian.couder, usman.akinyemi, Queen Ediri Jessa
Update the documentation to clearly describe how the server responds when a
client sends an invalid or malformed `want` line during the HTTP protocol
exchange. The server includes the offending object name in its error message.
Signed-off-by: Queen Ediri Jessa <qjessa662@gmail.com>
---
Changes since v3:
- Removed extra explanatory lines per reviewer feedback.
Documentation/gitprotocol-http.adoc | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/gitprotocol-http.adoc b/Documentation/gitprotocol-http.adoc
index d024010414..e2ef7f0459 100644
--- a/Documentation/gitprotocol-http.adoc
+++ b/Documentation/gitprotocol-http.adoc
@@ -443,7 +443,8 @@ If no "want" objects are received, send an error:
TODO: Define error if no "want" lines are requested.
If any "want" object is not reachable, send an error:
-TODO: Define error if an invalid "want" is requested.
+When a Git server receives an invalid or malformed `want` line, it
+responds with an error message that includes the offending object name.
Create an empty list, `s_common`.
--
2.51.0.573.gb660e2dcb9
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v4] doc: clarify server behavior for invalid 'want' lines in HTTP protocol
2025-11-05 14:38 [PATCH v4] doc: clarify server behavior for invalid 'want' lines in HTTP protocol Queen Ediri Jessa
@ 2025-11-06 17:46 ` Junio C Hamano
0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2025-11-06 17:46 UTC (permalink / raw)
To: Queen Ediri Jessa; +Cc: git, christian.couder, usman.akinyemi
Queen Ediri Jessa <qjessa662@gmail.com> writes:
> Update the documentation to clearly describe how the server responds when a
> client sends an invalid or malformed `want` line during the HTTP protocol
> exchange. The server includes the offending object name in its error message.
>
> Signed-off-by: Queen Ediri Jessa <qjessa662@gmail.com>
> ---
> Changes since v3:
> - Removed extra explanatory lines per reviewer feedback.
>
> Documentation/gitprotocol-http.adoc | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Thanks, will queue.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-11-06 17:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-05 14:38 [PATCH v4] doc: clarify server behavior for invalid 'want' lines in HTTP protocol Queen Ediri Jessa
2025-11-06 17:46 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).