From: Junio C Hamano <gitster@pobox.com>
To: Ben Knoble <ben.knoble@gmail.com>
Cc: Patrick Steinhardt <ps@pks.im>,
"D. Ben Knoble" <ben.knoble+github@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH] perl: also mark git-contacts executable
Date: Thu, 06 Nov 2025 07:28:15 -0800 [thread overview]
Message-ID: <xmqqikfnji40.fsf@gitster.g> (raw)
In-Reply-To: <87BB8F6A-7176-4C51-9F36-BA613E7D8B08@gmail.com> (Ben Knoble's message of "Thu, 6 Nov 2025 09:07:06 -0500")
Ben Knoble <ben.knoble@gmail.com> writes:
>> Le 6 nov. 2025 à 02:22, Patrick Steinhardt <ps@pks.im> a écrit :
>>
>> On Tue, Nov 04, 2025 at 01:14:57PM -0500, D. Ben Knoble wrote:
>>> When install git-contacts with Meson via -Dcontrib=contacts, the default
>>
>> s/install/installing/
>
> Thanks. If Junio doesn’t mind the trivial fix, I’ll avoid sending v2 for now :)
We'd be in pre-release freeze starting with -rc1, so no need to hurry.
>> And the change looks as expected. An alternative could of course be to
>> rename the file in-tree to "git-contacts.perl". In that case we wouldn't
>> require this special case at all. But I guess that this here is good
>> enough, and there might be other consequences if we renamed the script.
Heh, I tend to thnik that consistently naming any Perl source to end
in .perl (and Shell .sh) is the right fix, but anything in contrib/
is allowed to be sloppy ;-)
next prev parent reply other threads:[~2025-11-06 15:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-04 18:14 [PATCH] perl: also mark git-contacts executable D. Ben Knoble
2025-11-06 7:22 ` Patrick Steinhardt
2025-11-06 14:07 ` Ben Knoble
2025-11-06 15:28 ` Junio C Hamano [this message]
2025-11-11 0:19 ` [PATCH v2] " D. Ben Knoble
2025-11-11 18:59 ` Junio C Hamano
2025-11-11 19:00 ` D. Ben Knoble
2025-11-11 20:18 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqikfnji40.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=ben.knoble+github@gmail.com \
--cc=ben.knoble@gmail.com \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).