git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Peter Krefting <peter@softwolves.pp.se>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] refs: Add missing space in message
Date: Wed, 05 Nov 2025 15:03:03 -0800	[thread overview]
Message-ID: <xmqqikfokrq0.fsf@gitster.g> (raw)
In-Reply-To: <a8220721-3260-15cb-6960-ca8b6433d7b5@softwolves.pp.se> (Peter Krefting's message of "Wed, 5 Nov 2025 22:47:17 +0100 (CET)")

Peter Krefting <peter@softwolves.pp.se> writes:

> Signed-off-by: Peter Krefting <peter@softwolves.pp.se>
> ---
>  refs/files-backend.c    | 2 +-
>  refs/reftable-backend.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Good eyes.  Both of these came from 465eff81 (refs: fix invalid old
object IDs when migrating reflogs, 2025-08-06), which appeared in
Git 2.51.1 already.  Let's merge it before the upcoming release.

Thanks.


> diff --git a/refs/files-backend.c b/refs/files-backend.c
> index 054cf42f4e..1adc4b5182 100644
> --- a/refs/files-backend.c
> +++ b/refs/files-backend.c
> @@ -3124,7 +3124,7 @@ static int parse_and_write_reflog(struct files_ref_store *refs,
>  		if (!(update->flags & REF_HAVE_OLD) ||
>  		    !(update->flags & REF_HAVE_NEW) ||
>  		    !(update->flags & REF_LOG_ONLY)) {
> -			strbuf_addf(err, _("trying to write reflog for '%s'"
> +			strbuf_addf(err, _("trying to write reflog for '%s' "
>  					   "with incomplete values"), update->refname);
>  			return REF_TRANSACTION_ERROR_GENERIC;
>  		}
> diff --git a/refs/reftable-backend.c b/refs/reftable-backend.c
> index d4b7928620..eeec64798f 100644
> --- a/refs/reftable-backend.c
> +++ b/refs/reftable-backend.c
> @@ -1103,7 +1103,7 @@ static enum ref_transaction_error prepare_single_update(struct reftable_ref_stor
>  		if (!(u->flags & REF_HAVE_OLD) ||
>  		    !(u->flags & REF_HAVE_NEW) ||
>  		    !(u->flags & REF_LOG_ONLY)) {
> -			strbuf_addf(err, _("trying to write reflog for '%s'"
> +			strbuf_addf(err, _("trying to write reflog for '%s' "
>  					   "with incomplete values"), u->refname);
>  			return REF_TRANSACTION_ERROR_GENERIC;
>  		}

  reply	other threads:[~2025-11-05 23:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-05 21:47 [PATCH] refs: Add missing space in message Peter Krefting
2025-11-05 23:03 ` Junio C Hamano [this message]
2025-11-06 12:45   ` Peter Krefting

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqikfokrq0.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=peter@softwolves.pp.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).