From: Junio C Hamano <gitster@pobox.com>
To: Phillip Wood <phillip.wood123@gmail.com>
Cc: Patrick Steinhardt <ps@pks.im>, git@vger.kernel.org
Subject: Re: What's cooking in git.git (Jul 2025, #06; Tue, 22)
Date: Wed, 23 Jul 2025 10:17:08 -0700 [thread overview]
Message-ID: <xmqqikjiomi3.fsf@gitster.g> (raw)
In-Reply-To: <f1d3c903-b7c6-46b2-b911-0ec8c2708c8c@gmail.com> (Phillip Wood's message of "Wed, 23 Jul 2025 10:40:23 +0100")
Phillip Wood <phillip.wood123@gmail.com> writes:
>> I think the only commit that really needs review is the last one
>> that
>> fixes the sign comparison warnings. As long as people are fine with that
>> commit I'm happy to have it merged.
>
> I think that commit needs a re-roll
> c.f. <2b914b60-3417-4a49-b545-3109c9a05257@gmail.com>. I haven't
> looked at the rest of the patches but I like the general idea behind
> this series.
Thanks. I looked at the rest before marking it with the "next?" label
and they looked OK.
next prev parent reply other threads:[~2025-07-23 17:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-23 0:11 What's cooking in git.git (Jul 2025, #06; Tue, 22) Junio C Hamano
2025-07-23 5:35 ` Patrick Steinhardt
2025-07-23 9:40 ` Phillip Wood
2025-07-23 17:17 ` Junio C Hamano [this message]
2025-07-23 15:48 ` Junio C Hamano
2025-07-23 7:40 ` Eric Sunshine
2025-07-23 16:46 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqikjiomi3.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=phillip.wood123@gmail.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).