Re: [PATCH] contrib: Honor symbolic port in git-credential-netrc.

brian m. carlson
2025-06-20T19:03:25Z

[-- Attachment #1: Type: text/plain, Size: 1201 bytes --]

On 2025-06-20 at 04:12:39, Maxim Cournoyer wrote:
> Symbolic ports were previously silently dropped, which made it
> impossible to use them with git-credential-netrc. This is a supported
> use case according to 'man git-send-email', for --smtp-server-port:
>
> [...] symbolic port names (e.g. "submission" instead of 587) are
> also accepted.

Does this work with credential managers in general (that is, in
non-email contexts, such as HTTP)? Also, do credential managers in
general properly find credentials when they're stored in one form and
looked up in another? If so, is that still true when the lookup is in
the URL form (e.g., `smtp://mail.example.com:587/`)? Is this documented
to work in the credential manual page? (To be clear, I would be very
surprised if the answer to any of these were "yes" because I've
literally never seen this usage before with Git, but I am open to
updating my knowledge if that's the case.)

If not, then I think the proper thing to do is to have `git send-email`
rewrite the name into a port instead of having the netrc credential
helper learn to handle non-numeric ports.
--
brian m. carlson (they/them)
Toronto, Ontario, CA

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 262 bytes --]