From: Junio C Hamano <gitster@pobox.com>
To: Rodrigo Michelassi <rodmichelassi@gmail.com>
Cc: git@vger.kernel.org, icaselli@usp.br
Subject: Re: [PATCH v4] t2400: replace 'test -[efd]' with 'test_path_is_*'
Date: Tue, 17 Jun 2025 06:10:56 -0700 [thread overview]
Message-ID: <xmqqikkuy0m7.fsf@gitster.g> (raw)
In-Reply-To: <20250617002939.24478-1-rodmichelassi@gmail.com> (Rodrigo Michelassi's message of "Mon, 16 Jun 2025 21:29:39 -0300")
Rodrigo Michelassi <rodmichelassi@gmail.com> writes:
> 'test_path_is_file', 'test_path_is_dir' and 'test_file_is_missing'
> are test helpers used in Git's development, that emit useful
> diagnostic information when they detect a failing condition, while
> test -[efd] does not.
> Replace the basic shell commands 'test -f', 'test -d' and 'test -e',
> with this modern path checking approach.
>
> Co-authored-by: Isabella Caselli <icaselli@usp.br>
> Signed-off-by: Isabella Caselli <icaselli@usp.br>
> Signed-off-by: Rodrigo Michelassi <rodmichelassi@gmail.com>
> ---
> t/t2400-worktree-add.sh | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
Looking good. Will queue.
Thanks.
prev parent reply other threads:[~2025-06-17 13:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-17 0:29 [PATCH v4] t2400: replace 'test -[efd]' with 'test_path_is_*' Rodrigo Michelassi
2025-06-17 13:10 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqikkuy0m7.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=icaselli@usp.br \
--cc=rodmichelassi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).