git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Karthik Nayak <karthik.188@gmail.com>
Cc: git@vger.kernel.org,  Patrick Steinhardt <ps@pks.im>,
	 Jeff King <peff@peff.net>
Subject: Re: [PATCH] install meson for Documentation job
Date: Tue, 18 Mar 2025 13:40:07 -0700	[thread overview]
Message-ID: <xmqqiko613a0.fsf@gitster.g> (raw)
In-Reply-To: <CAOLa=ZRODjYfDXQ8m+hDosV7RBGDWeehzSvsR-+-HCmbS+tAcQ@mail.gmail.com> (Karthik Nayak's message of "Tue, 18 Mar 2025 16:19:31 +0000")

Karthik Nayak <karthik.188@gmail.com> writes:

> Weird. From the looks of
> https://github.com/git/git/actions/runs/13867157977/job/38808418127, it
> seems like the '$distro' variable in 'ci/install-dependencies.sh' is not
> being correctly initialized. We can see this in the logs of the CI:
>
>   CI setup via install-dependencies.sh
>     + set -e
>     + export TERM=dumb
>     + export MAKEFLAGS=
>     + test true = true
>     + CI_TYPE=github-actions
>     + CI_BRANCH=refs/heads/seen
>     + CI_COMMIT=d5389e37e21d864f40f4167280db799ffe8983c2
>     + echo Linux
>     + tr A-Z a-z
>     + CI_OS_NAME=linux
>     + test macos != linux
>     + CI_REPO_SLUG=git/git
>     + CI_JOB_ID=13867157977
>     + CC=gcc
>     + DONT_SKIP_TAGS=t
>     + cache_dir=/home/runner/none
>     + GIT_TEST_OPTS=--github-workflow-markup
>     + JOBS=10
>     + echo
>     + tr : -
>     + distro=
>     ...

Nice digging.

> So in 'ci/lib.sh' we set `distro=$(echo "$CI_JOB_IMAGE" | tr : -)`. So
> this means the distro is based on '$CI_JOB_IMAGE' env variable.
>
> From '.github/workflows/main.yml' we can see that this is not set for
> the 'Documentation' job. I'm not sure why this the way it is though. I
> didn't look into the history.

  reply	other threads:[~2025-03-18 20:40 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-14 17:36 What's cooking in git.git (Mar 2025, #04; Fri, 14) Junio C Hamano
2025-03-14 18:41 ` Jeff King
2025-03-14 18:42   ` Jeff King
2025-03-15  0:02   ` Junio C Hamano
2025-03-18 15:57     ` [PATCH] install meson for Documentation job Junio C Hamano
2025-03-18 16:19       ` Karthik Nayak
2025-03-18 20:40         ` Junio C Hamano [this message]
2025-03-19  9:24           ` Patrick Steinhardt
2025-03-19 16:22             ` Karthik Nayak
2025-03-19 16:33             ` [PATCH] ci/github: add missing 'CI_JOB_IMAGE' env variable Karthik Nayak
2025-03-20  7:10               ` Patrick Steinhardt
2025-03-21  7:51               ` Junio C Hamano
2025-03-20 20:27             ` [PATCH] install meson for Documentation job Junio C Hamano
2025-03-15  0:32 ` en/diff-rename-follow-fix (Was: Re: What's cooking in git.git (Mar 2025, #04; Fri, 14)) Elijah Newren
2025-03-15  1:22   ` en/diff-rename-follow-fix Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqiko613a0.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=karthik.188@gmail.com \
    --cc=peff@peff.net \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).