From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Koji Nakamaru <koji.nakamaru@gree.net>,
Koji Nakamaru via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH 0/2] alternate approach to fixing fsmonitor hangs
Date: Fri, 11 Oct 2024 11:01:12 -0700 [thread overview]
Message-ID: <xmqqiktyecyf.fsf@gitster.g> (raw)
In-Reply-To: <20241011090051.GA563709@coredump.intra.peff.net> (Jeff King's message of "Fri, 11 Oct 2024 05:00:51 -0400")
Jeff King <peff@peff.net> writes:
> On Wed, Oct 09, 2024 at 01:03:14AM +0900, Koji Nakamaru wrote:
>
>> > But I've cleaned it up for presentation here, so at least we can look at
>> > the final form of both and see which we prefer.
>>
>> Thank you for the new patch. It prevents to start accepting requests
>> until starting fs event listening and simplifies the code flow. It also
>> has sufficient comments, so later everyone can easily understand how it
>> works. I also tested it both on mac and windows and it works correctly.
>>
>> I think this one should be adopted :)
>
> Thanks for reviewing, and for all your work identifying the problem in
> the first place! Looks like Junio has picked up my patch and it's
> already in 'next', so hopefully these 6-hour CI timeouts will soon be a
> thing of the past. :)
Yup. Thanks, both of you.
prev parent reply other threads:[~2024-10-11 18:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-02 9:47 [PATCH] fsmonitor: fix hangs by delayed fs event listening Koji Nakamaru via GitGitGadget
2024-10-07 5:58 ` Jeff King
2024-10-07 6:08 ` Jeff King
2024-10-07 9:45 ` Koji Nakamaru
2024-10-08 8:31 ` [PATCH 0/2] alternate approach to fixing fsmonitor hangs Jeff King
2024-10-08 8:33 ` [PATCH 1/2] simple-ipc: split async server initialization and running Jeff King
2024-10-08 8:36 ` [PATCH 2/2] fsmonitor: initialize fs event listener before accepting clients Jeff King
2024-10-08 16:03 ` [PATCH 0/2] alternate approach to fixing fsmonitor hangs Koji Nakamaru
2024-10-11 9:00 ` Jeff King
2024-10-11 18:01 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqiktyecyf.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=koji.nakamaru@gree.net \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).