From: Junio C Hamano <gitster@pobox.com>
To: "James Liu" <james@jamesliu.io>
Cc: "Patrick Steinhardt" <ps@pks.im>, <git@vger.kernel.org>
Subject: Re: [PATCH 1/4] Makefile: extract script to lint missing/extraneous manpages
Date: Wed, 05 Jun 2024 23:12:04 -0700 [thread overview]
Message-ID: <xmqqikymppl7.fsf@gitster.g> (raw)
In-Reply-To: <D1SPGQ8OOLLS.I6HUJZW81XLH@jamesliu.io> (James Liu's message of "Thu, 06 Jun 2024 16:03:45 +1000")
"James Liu" <james@jamesliu.io> writes:
> On Wed Jun 5, 2024 at 3:27 PM AEST, Patrick Steinhardt wrote:
>> On Tue, Jun 04, 2024 at 10:20:54PM -0700, Junio C Hamano wrote:
>> > Patrick Steinhardt <ps@pks.im> writes:
>> >
>> > > +++ b/Documentation/lint-manpages.sh
>> > > @@ -0,0 +1,82 @@
>> > > +#!/usr/bin/env bash
>> >
>> > I do not see much bash-ism here. Unless absolutely needed, please
>> > use "#!/bin/sh" instead.
>>
>> Ah, true. I initially did have some bash-isms, but got rid of them. Will
>> adapt.
>>
>> Patrick
>
> It looks like the script fails to run under /bin/sh:
> https://gitlab.com/gitlab-org/git/-/jobs/7021474555#L4365
Nice to know. In any case, the original was an inline scriptlet in
the Makefile and should have been happily working for folks whose
/bin/sh is different from bash, so the version that is extracted out
shouldn't have to rely on bashisms.
Thanks.
next prev parent reply other threads:[~2024-06-06 6:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-05 5:16 [PATCH 0/4] Documentation: improve linting of manpage existence Patrick Steinhardt
2024-06-05 5:16 ` [PATCH 1/4] Makefile: extract script to lint missing/extraneous manpages Patrick Steinhardt
2024-06-05 5:20 ` Junio C Hamano
2024-06-05 5:27 ` Patrick Steinhardt
2024-06-06 6:03 ` James Liu
2024-06-06 6:12 ` Junio C Hamano [this message]
2024-06-05 5:16 ` [PATCH 2/4] Documentation/lint-manpages: bubble up errors Patrick Steinhardt
2024-06-05 5:22 ` Junio C Hamano
2024-06-05 5:16 ` [PATCH 3/4] gitlab-ci: add job to run `make check-docs` Patrick Steinhardt
2024-06-05 5:17 ` [PATCH 4/4] ci/test-documentation: work around SyntaxWarning in Python 3.12 Patrick Steinhardt
2024-06-05 5:24 ` Junio C Hamano
2024-06-06 8:00 ` [PATCH v2 0/4] Documentation: improve linting for manpage existence Patrick Steinhardt
2024-06-06 8:01 ` [PATCH v2 1/4] Makefile: extract script to lint missing/extraneous manpages Patrick Steinhardt
2024-06-07 16:51 ` Junio C Hamano
2024-06-06 8:01 ` [PATCH v2 2/4] Documentation/lint-manpages: bubble up errors Patrick Steinhardt
2024-06-06 8:01 ` [PATCH v2 3/4] gitlab-ci: add job to run `make check-docs` Patrick Steinhardt
2024-06-06 8:01 ` [PATCH v2 4/4] ci/test-documentation: work around SyntaxWarning in Python 3.12 Patrick Steinhardt
2024-06-07 0:59 ` [PATCH v2 0/4] Documentation: improve linting for manpage existence James Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqikymppl7.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=james@jamesliu.io \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).