git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Christian Couder <christian.couder@gmail.com>
Cc: git@vger.kernel.org,  Patrick Steinhardt <ps@pks.im>,
	 John Cai <johncai86@gmail.com>,
	 Christian Couder <chriscool@tuxfamily.org>
Subject: Re: [PATCH 3/3] rev-list: add --allow-missing-tips to be used with --missing=...
Date: Thu, 01 Feb 2024 13:27:22 -0800	[thread overview]
Message-ID: <xmqqil37yix1.fsf@gitster.g> (raw)
In-Reply-To: <20240201115809.1177064-4-christian.couder@gmail.com> (Christian Couder's message of "Thu, 1 Feb 2024 12:58:09 +0100")

Christian Couder <christian.couder@gmail.com> writes:

> When such a command is used to find the dependencies of some objects,
> for example the dependencies of quarantined objects, it would be
> better if the command would instead consider such missing objects,
> especially commits, in the same way as other missing objects.
>
> If, for example `--missing=print` is used, it would be nice for some
> use cases if the missing tips passed as arguments were reported in
> the same way as other missing objects instead of the command just
> failing.
>
> Let's introduce a new `--allow-missing-tips` option to make it work
> like this.

An obvious question is if this even needs to be a new option.  What
are expected use cases where --missing=print without this option is
beneficial?  If there is no plausible use case, perhaps we can treat
it as a mere bugfix to the existing --missing mechanism, especially
given that support of commits in "--missing" itself is relatively
a new thing.

If we can do this as a bugfix that is always on when --missing is
used, then we do not have to worry about adding another tasteless
loop outside the main command line parser, which is a huge upside
;-).

  parent reply	other threads:[~2024-02-01 21:27 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-01 11:58 [PATCH 0/3] rev-list: allow missing tips with --missing Christian Couder
2024-02-01 11:58 ` [PATCH 1/3] revision: clarify a 'return NULL' in get_reference() Christian Couder
2024-02-01 14:53   ` Eric Sunshine
2024-02-01 16:49     ` Christian Couder
2024-02-01 11:58 ` [PATCH 2/3] t6022: fix 'even though' typo in comment Christian Couder
2024-02-01 11:58 ` [PATCH 3/3] rev-list: add --allow-missing-tips to be used with --missing= Christian Couder
2024-02-01 20:20   ` Junio C Hamano
2024-02-02 11:29     ` Christian Couder
2024-02-02 16:47       ` Junio C Hamano
2024-02-01 21:27   ` Junio C Hamano [this message]
2024-02-02 11:29     ` Christian Couder
2024-02-02 16:54       ` Junio C Hamano
2024-02-07  9:57       ` Linus Arver
2024-02-07 16:34         ` Junio C Hamano
2024-02-07 16:38         ` Christian Couder
2024-02-07  9:40   ` Linus Arver
2024-02-07 16:11     ` Christian Couder
2024-02-07 20:48       ` Linus Arver
2024-02-08 15:03         ` Christian Couder
2024-02-08 20:42           ` Linus Arver

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqil37yix1.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=chriscool@tuxfamily.org \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=johncai86@gmail.com \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).