From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: Kristoffer Haugsbakk <code@khaugsbakk.name>, git@vger.kernel.org
Subject: Re: [PATCH 1/1] config: add back code comment
Date: Mon, 29 Jan 2024 10:28:16 -0800 [thread overview]
Message-ID: <xmqqil3chu4f.fsf@gitster.g> (raw)
In-Reply-To: <ZbeMw5tgY9S6k6y6@tanuki> (Patrick Steinhardt's message of "Mon, 29 Jan 2024 12:32:19 +0100")
Patrick Steinhardt <ps@pks.im> writes:
>> if (!given_config_source.file)
>> + /*
>> + * It is unknown if HOME/.gitconfig exists, so
>> + * we do not know if we should write to XDG
>> + * location; error out even if XDG_CONFIG_HOME
>> + * is set and points at a sane location.
>> + */
>> die(_("$HOME not set"));
>> given_config_source.scope = CONFIG_SCOPE_GLOBAL;
>> } else if (use_system_config) {
>
> Thanks for adding the comment back in! The patch looks good to me.
Yeah, thanks, both.
next prev parent reply other threads:[~2024-01-29 18:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-28 18:31 [PATCH 0/1] config: add back code comment Kristoffer Haugsbakk
2024-01-28 18:31 ` [PATCH 1/1] " Kristoffer Haugsbakk
2024-01-29 11:32 ` Patrick Steinhardt
2024-01-29 18:28 ` Junio C Hamano [this message]
2024-01-29 17:57 ` [PATCH v2 0/1] " Kristoffer Haugsbakk
2024-01-29 17:57 ` [PATCH v2 1/1] " Kristoffer Haugsbakk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqil3chu4f.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=code@khaugsbakk.name \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).