From: Junio C Hamano <gitster@pobox.com>
To: Todd Zullinger <tmz@pobox.com>
Cc: Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org,
Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH] completion(switch/checkout): treat --track and -t the same
Date: Fri, 08 Sep 2023 09:25:48 -0700 [thread overview]
Message-ID: <xmqqil8ktywj.fsf@gitster.g> (raw)
In-Reply-To: <ZPtISYVufU0MazO_@pobox.com> (Todd Zullinger's message of "Fri, 8 Sep 2023 12:14:01 -0400")
Todd Zullinger <tmz@pobox.com> writes:
> Junio C Hamano wrote:
>> "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
>> writes:
>>> diff --git a/t/t9902-completion.sh b/t/t9902-completion.sh
>>> index 8835e16e811..df8bc44c285 100755
>>> --- a/t/t9902-completion.sh
>>> +++ b/t/t9902-completion.sh
>>> @@ -1622,14 +1622,22 @@ test_expect_success 'git checkout - with -d, complete only references' '
>>> '
>>>
>>> test_expect_success 'git switch - with --track, complete only remote branches' '
>>> - test_completion "git switch --track " <<-\EOF
>>> +: test_completion "git switch --track " <<-\EOF &&
>
> Is this new leading ":" intended? It looks out of place
> (though perhaps I just don't unerstand the context well
> enough).
Good eyes. It makes it an expensive no-op ;-)
next prev parent reply other threads:[~2023-09-08 16:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-08 12:28 [PATCH] completion(switch/checkout): treat --track and -t the same Johannes Schindelin via GitGitGadget
2023-09-08 15:51 ` Junio C Hamano
2023-09-08 16:14 ` Todd Zullinger
2023-09-08 16:25 ` Junio C Hamano [this message]
2023-09-10 8:22 ` Johannes Schindelin
2023-09-11 6:09 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqil8ktywj.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=johannes.schindelin@gmx.de \
--cc=tmz@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).