From: Junio C Hamano <gitster@pobox.com>
To: Wesley Schwengle <wesleys@opperschaap.net>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>
Subject: Re: [PATCH] Fix bug when more than one readline instance is used
Date: Wed, 09 Aug 2023 18:05:33 -0700 [thread overview]
Message-ID: <xmqqil9nk8pu.fsf@gitster.g> (raw)
In-Reply-To: <20230810003939.1420306-1-wesleys@opperschaap.net> (Wesley Schwengle's message of "Wed, 9 Aug 2023 20:39:33 -0400")
Wesley Schwengle <wesleys@opperschaap.net> writes:
If I recall correctly, this was fixed by Peff yesterday?
https://lore.kernel.org/git/20230808181531.GB2097200@coredump.intra.peff.net/
> diff --git a/git-send-email.perl b/git-send-email.perl
> index affbb88509..7fdcf9084a 100755
> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -971,8 +971,10 @@ sub get_patch_subject {
> do_edit(@files);
> }
>
> +my $term;
> sub term {
> - my $term = eval {
> + return $term if $term;
> + $term = eval {
> require Term::ReadLine;
> $ENV{"GIT_SEND_EMAIL_NOTTY"}
> ? Term::ReadLine->new('git-send-email', \*STDIN, \*STDOUT)
The patch I queued yesterday wraps this lexical inside another block
to hide it from the outside, but otherwise it should achieve the
same goal.
prev parent reply other threads:[~2023-08-10 1:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-10 0:39 [PATCH] Fix bug when more than one readline instance is used Wesley Schwengle
2023-08-10 0:49 ` Jeff King
2023-08-10 1:18 ` [[PATCH v2]] " Wesley Schwengle
2023-08-10 14:31 ` Junio C Hamano
2023-08-10 15:14 ` Wesley
2023-08-11 1:01 ` Junio C Hamano
2023-08-11 1:09 ` Wesley
2023-08-11 5:30 ` Junio C Hamano
2023-08-11 14:51 ` Jeff King
2023-08-11 16:05 ` Junio C Hamano
2023-08-30 22:32 ` [PATCH] git-svn: drop FakeTerm hack Junio C Hamano
2023-08-31 0:13 ` Jeff King
2023-08-31 0:28 ` Junio C Hamano
2023-08-10 1:05 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqil9nk8pu.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=wesleys@opperschaap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).