From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] t9800: correct misuse of 'show -s --raw' in a test
Date: Mon, 08 May 2023 13:53:22 -0700 [thread overview]
Message-ID: <xmqqild2mtod.fsf@gitster.g> (raw)
In-Reply-To: <20230508185545.GA1893355@coredump.intra.peff.net> (Jeff King's message of "Mon, 8 May 2023 14:55:45 -0400")
Jeff King <peff@peff.net> writes:
>> * It appears pretty obvious that the original wanted to just grab
>> the %at timestamp of the HEAD, and with the fix to allow output
>> format options to take effect after "-s" is given, the existing
>> misuse of "--raw" after "-s" that ought to be a no-op breaks the
>> test.
>
> Yes, I think this is matching what the original code was trying to do.
> The patch looks good to me.
Thanks.
This still can be a cause for backward compatibility worry, though.
I do not think anybody would have lifted $(git show -s --raw --format=%ad)
as a way to get the author timestamp from this test script, but it
is entirely possible that this was written by the author who saw it
done (incorrectly) that way elsewhere, and who knows how many others
copied that (incorrect) way of using "-s --raw" from that original
source we have no control over.
Anyway.
prev parent reply other threads:[~2023-05-08 20:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-06 21:29 [PATCH] t9800: correct misuse of 'show -s --raw' in a test Junio C Hamano
2023-05-08 18:55 ` Jeff King
2023-05-08 20:53 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqild2mtod.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).