From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
git@vger.kernel.org,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
"Phillip Wood" <phillip.wood@dunelm.org.uk>,
"Slavica Đukić" <slawica92@hotmail.com>
Subject: Re: [PATCH 0/3] add: remove Perl version of "git add -[pi]"
Date: Fri, 03 Feb 2023 11:34:12 -0800 [thread overview]
Message-ID: <xmqqilgio85n.fsf@gitster.g> (raw)
In-Reply-To: <Y906yEGFEIglRyVb@coredump.intra.peff.net> (Jeff King's message of "Fri, 3 Feb 2023 11:48:08 -0500")
Jeff King <peff@peff.net> writes:
> On Fri, Feb 03, 2023 at 05:30:01PM +0100, Ævar Arnfjörð Bjarmason wrote:
>
>> After it was made the default we had a next-release regression fix[1],
>> but haven't had any issues since then. Any outstanding bugs in it are
>> something we'd fix in the C code, not something where users are likely
>> to want an escape hatch to scramble back to the Perl implementation.
>
> I'm in favor of dropping the perl version, but note that this paragraph
> isn't quite accurate. There was at least one more regression after that,
> solved by fb094cb583 (Merge branch 'js/add-p-diff-parsing-fix',
> 2022-09-09).
>
> I'd probably leave the final decision on its status to Johannes. This is
> (I think) the last time we discussed it:
>
> https://lore.kernel.org/git/rsrn5988-37n4-7q45-s1o9-6n40rropp120@tzk.qr/
>
> That was 6 months ago, so maybe it's time now.
Sounds good to me, too.
next prev parent reply other threads:[~2023-02-03 19:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 16:30 [PATCH 0/3] add: remove Perl version of "git add -[pi]" Ævar Arnfjörð Bjarmason
2023-02-03 16:30 ` [PATCH 1/3] add: remove "add.interactive.useBuiltin" & Perl "git add--interactive" Ævar Arnfjörð Bjarmason
2023-02-06 18:38 ` Philippe Blain
2023-02-03 16:30 ` [PATCH 2/3] add API: remove run_add_interactive() wrapper function Ævar Arnfjörð Bjarmason
2023-02-03 16:30 ` [PATCH 3/3] docs & comments: replace mentions of "git-add--interactive.perl" Ævar Arnfjörð Bjarmason
2023-02-03 16:48 ` [PATCH 0/3] add: remove Perl version of "git add -[pi]" Jeff King
2023-02-03 19:34 ` Junio C Hamano [this message]
2023-02-06 22:58 ` [PATCH v2 " Ævar Arnfjörð Bjarmason
2023-02-06 22:58 ` [PATCH v2 1/3] add: remove "add.interactive.useBuiltin" & Perl "git add--interactive" Ævar Arnfjörð Bjarmason
2023-02-06 22:58 ` [PATCH v2 2/3] add API: remove run_add_interactive() wrapper function Ævar Arnfjörð Bjarmason
2023-02-06 22:58 ` [PATCH v2 3/3] docs & comments: replace mentions of "git-add--interactive.perl" Ævar Arnfjörð Bjarmason
2023-02-06 23:04 ` [PATCH v2 0/3] add: remove Perl version of "git add -[pi]" Junio C Hamano
2023-02-07 10:21 ` Phillip Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqilgio85n.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=phillip.wood@dunelm.org.uk \
--cc=slawica92@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).