From: Junio C Hamano <gitster@pobox.com>
To: "René Scharfe" <l.s.r@web.de>
Cc: Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org,
Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH 01/11] mingw: avoid accessing uninitialized memory in `is_executable()`
Date: Thu, 16 Jun 2022 13:20:39 -0700 [thread overview]
Message-ID: <xmqqilp0s6lk.fsf@gitster.g> (raw)
In-Reply-To: <xmqqmtecs6ws.fsf@gitster.g> (Junio C. Hamano's message of "Thu, 16 Jun 2022 13:13:55 -0700")
Junio C Hamano <gitster@pobox.com> writes:
>> Hmm, but buf _is_ initialized fully? Line 149:
>>
>> char buf[3] = { 0 };
>
> Ahh, yeah, that changes the landscape quite a bit.
Just for reference, this piece of code has been correct ever since
it was introduced to help.c by cc3b7a97 (Windows: Make 'git help -a'
work., 2008-01-14). With a larger context, we can see buf[3] that
is NUL filled, which receives 2 bytes by read(), and strcmp() does
look semantically more correct than memcmp(), even though there
probably shouldn't be any correctness or performance difference.
So, strcmp -> memcmp in this case is a strict dis-improvement. I
merged it already to 'next', but I haven't pushed the result out, so
I'll redo 'next' before I push the result out.
Thanks.
next prev parent reply other threads:[~2022-06-16 20:20 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-15 23:35 [PATCH 00/11] Coverity fixes Johannes Schindelin via GitGitGadget
2022-06-15 23:35 ` [PATCH 01/11] mingw: avoid accessing uninitialized memory in `is_executable()` Johannes Schindelin via GitGitGadget
2022-06-16 4:07 ` Junio C Hamano
2022-06-16 19:53 ` René Scharfe
2022-06-16 20:13 ` Junio C Hamano
2022-06-16 20:20 ` Junio C Hamano [this message]
2022-06-15 23:35 ` [PATCH 02/11] fsmonitor: avoid memory leak in `fsm_settings__get_incompatible_msg()` Johannes Schindelin via GitGitGadget
2022-06-16 4:10 ` Junio C Hamano
2022-06-15 23:35 ` [PATCH 03/11] submodule--helper: avoid memory leak in `update_submodule()` Johannes Schindelin via GitGitGadget
2022-06-16 4:23 ` Junio C Hamano
2022-06-16 17:51 ` Glen Choo
2022-06-15 23:35 ` [PATCH 04/11] get_oid_with_context_1(): avoid use-after-free Johannes Schindelin via GitGitGadget
2022-06-16 4:29 ` Junio C Hamano
2022-06-15 23:35 ` [PATCH 05/11] submodule-config: avoid memory leak Johannes Schindelin via GitGitGadget
2022-06-16 4:36 ` Junio C Hamano
2022-06-16 18:09 ` Glen Choo
2022-06-15 23:35 ` [PATCH 06/11] pack-redundant: avoid using uninitialized memory Johannes Schindelin via GitGitGadget
2022-06-16 4:53 ` Junio C Hamano
2022-06-15 23:35 ` [PATCH 07/11] submodule--helper: avoid memory leak when fetching submodules Johannes Schindelin via GitGitGadget
2022-06-16 4:55 ` Junio C Hamano
2022-06-15 23:35 ` [PATCH 08/11] read_index_from(): avoid memory leak Johannes Schindelin via GitGitGadget
2022-06-17 21:27 ` Tom Levy
2022-06-15 23:35 ` [PATCH 09/11] pack-mtimes: avoid closing a bogus file descriptor Johannes Schindelin via GitGitGadget
2022-06-16 20:43 ` Taylor Blau
2022-06-15 23:35 ` [PATCH 10/11] relative_url(): fix incorrect condition Johannes Schindelin via GitGitGadget
2022-06-16 5:02 ` Junio C Hamano
2022-06-16 13:09 ` Ævar Arnfjörð Bjarmason
2022-06-16 17:55 ` Junio C Hamano
2022-06-16 16:41 ` Junio C Hamano
2022-06-15 23:35 ` [PATCH 11/11] bug_fl(): add missing `va_end()` call Johannes Schindelin via GitGitGadget
2022-06-16 4:53 ` Jeff King
2022-06-16 5:00 ` Junio C Hamano
2022-06-16 13:02 ` Ævar Arnfjörð Bjarmason
2022-06-16 18:03 ` Junio C Hamano
2022-06-16 19:20 ` Jeff King
2022-06-16 20:04 ` [PATCH] bug_fl(): correctly initialize trace2 va_list Jeff King
2022-06-16 20:11 ` [PATCH 11/11] bug_fl(): add missing `va_end()` call Junio C Hamano
2022-06-16 4:05 ` [PATCH 00/11] Coverity fixes Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqilp0s6lk.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=johannes.schindelin@gmx.de \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).