From: Junio C Hamano <gitster@pobox.com>
To: Fangyi Zhou <me@fangyi.io>
Cc: git@vger.kernel.org, Josh Steadmon <steadmon@google.com>
Subject: Re: [PATCH] submodule-helper: Fix a missing space
Date: Thu, 07 Apr 2022 07:46:06 -0700 [thread overview]
Message-ID: <xmqqilrluf2p.fsf@gitster.g> (raw)
In-Reply-To: <20220406203256.16100-1-me@fangyi.io> (Fangyi Zhou's message of "Wed, 6 Apr 2022 21:32:57 +0100")
Fangyi Zhou <me@fangyi.io> writes:
> The missing space at the end of the line makes the closing square
> bracket sticking to the dash in the next line
>
> Found during localisation v2.36.0 round 1
>
> Signed-off-by: Fangyi Zhou <me@fangyi.io>
> ---
As this is new in 2.36, let's queue it for -rc1.
Thanks.
> builtin/submodule--helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
> index c3e0d4570f..0b8b226c8f 100644
> --- a/builtin/submodule--helper.c
> +++ b/builtin/submodule--helper.c
> @@ -1902,7 +1902,7 @@ static int module_clone(int argc, const char **argv, const char *prefix)
> const char *const git_submodule_helper_usage[] = {
> N_("git submodule--helper clone [--prefix=<path>] [--quiet] "
> "[--reference <repository>] [--name <name>] [--depth <depth>] "
> - "[--single-branch] [--filter <filter-spec>]"
> + "[--single-branch] [--filter <filter-spec>] "
> "--url <url> --path <path>"),
> NULL
> };
prev parent reply other threads:[~2022-04-07 14:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-06 20:32 [PATCH] submodule-helper: Fix a missing space Fangyi Zhou
2022-04-07 14:46 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqilrluf2p.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=me@fangyi.io \
--cc=steadmon@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).