From: Junio C Hamano <gitster@pobox.com>
To: Jerry Zhang <jerry@skydio.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH V3] git-rev-list: add --first-parent-not flag
Date: Fri, 07 Jan 2022 13:02:18 -0800 [thread overview]
Message-ID: <xmqqiluv8dk5.fsf@gitster.g> (raw)
In-Reply-To: <CAMKO5CsGJdDYvBsb8_-AkpAeeoVGY0Qhv4sX8TimJ4eqR=sLvA@mail.gmail.com> (Jerry Zhang's message of "Thu, 6 Jan 2022 19:51:48 -0800")
Jerry Zhang <jerry@skydio.com> writes:
>> Assuming that propagating the UNINTERESTING bit only along the first
>> parent chain is a way to achieve some meaningful result (which, as I
>> said, I am not convinced about), I probably would call this option
>> "--exclude-first-parent-only" and explain it perhaps like so
>>
>> Follow only the first-parent chain from commits given with a
>> {caret} in front of them, to find commits to exclude.
>>
>> This prevents commits merged from the side branches from
>> becoming uninteresting and instead be shown if they are
>> reachable from the positive end of the range.
>>
>> I am debating myself if the second paragraph is necessary, though.
>> I suspect that the first two-line paragraph may be sufficient.
> Sure, I'll update the patch and commit text with these changes.
OK. Also the log message for the commit needs to be updated so that
those who read "git log" and find the commit for this change will
not have to ask the same question as I asked.
Thanks.
next prev parent reply other threads:[~2022-01-07 21:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-05 23:27 [PATCH V3] git-rev-list: add --first-parent-not flag Jerry Zhang
2022-01-06 22:10 ` Junio C Hamano
2022-01-07 3:51 ` Jerry Zhang
2022-01-07 21:02 ` Junio C Hamano [this message]
2022-01-11 21:39 ` [PATCH V4] git-rev-list: add --exclude-first-parent-only flag Jerry Zhang
-- strict thread matches above, loose matches on Subject: below --
2021-04-21 0:48 [PATCH V2] git-rev-list: add --first-parent-not flag Jerry Zhang
2021-07-28 3:20 ` [PATCH V3] " Jerry Zhang
2021-12-11 2:13 ` Jerry Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqiluv8dk5.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jerry@skydio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).