From: Junio C Hamano <gitster@pobox.com>
To: Philippe Blain <levraiphilippeblain@gmail.com>
Cc: Jeff King <peff@peff.net>,
git@vger.kernel.org,
Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Subject: Re: [PATCH] Docs: web server must setenv GIT_PROTOCOL for v2
Date: Thu, 09 Sep 2021 22:39:29 -0700 [thread overview]
Message-ID: <xmqqilz9ugz2.fsf@gitster.g> (raw)
In-Reply-To: <64a5aaf1-64af-3599-8520-ff3b55411e2a@gmail.com> (Philippe Blain's message of "Thu, 9 Sep 2021 13:50:18 -0400")
Philippe Blain <levraiphilippeblain@gmail.com> writes:
> I agree it's nice to make it work out of the box, without the web server
> admin having to configure anything. But, I'm not sure we should completely
> drop the documentation patches: your patch will only affect future versions
> of git-http-backend, and users of previous versions will be left without
> any documentation as to how to configure it for protocol v2. So I would think we should
> keep the documentation patches, maybe with a mention "this should not be necessary
> in Git 2.34 and later versions" or something like that (since your
> commit message mentions that it "generally" should work like that depending
> on the web servers).
Thanks, exactly my thought on the need for docs.
next prev parent reply other threads:[~2021-09-10 5:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-04 15:17 [PATCH] Docs: web server must setenv GIT_PROTOCOL for v2 Konstantin Ryabitsev
2021-09-04 15:55 ` Jeff King
2021-09-07 20:57 ` Junio C Hamano
2021-09-07 21:11 ` Konstantin Ryabitsev
2021-09-08 10:48 ` Jeff King
2021-09-08 10:57 ` Jeff King
2021-09-08 16:50 ` Eric Wong
2021-09-09 17:28 ` Junio C Hamano
2021-09-09 17:35 ` Junio C Hamano
2021-09-10 11:39 ` Jeff King
2021-09-10 14:02 ` Jeff King
2021-09-10 14:04 ` [PATCH 1/5] t5551: test v2-to-v0 http protocol fallback Jeff King
2021-09-10 14:05 ` [PATCH 2/5] http-backend: handle HTTP_GIT_PROTOCOL CGI variable Jeff King
2021-09-10 14:09 ` [PATCH 3/5] docs/http-backend: mention v2 protocol Jeff King
2021-09-10 14:09 ` [PATCH 4/5] docs/git: discuss server-side config for GIT_PROTOCOL Jeff King
2021-09-10 14:10 ` [PATCH 5/5] docs/protocol-v2: point readers transport config discussion Jeff King
2021-09-10 22:08 ` [PATCH] Docs: web server must setenv GIT_PROTOCOL for v2 Junio C Hamano
2021-09-09 17:50 ` Philippe Blain
2021-09-10 5:39 ` Junio C Hamano [this message]
2021-09-10 11:40 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqilz9ugz2.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=konstantin@linuxfoundation.org \
--cc=levraiphilippeblain@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).