From: Junio C Hamano <gitster@pobox.com>
To: "Randall S. Becker" <rsbecker@nexbridge.com>
Cc: <git@vger.kernel.org>
Subject: Re: [Bug] worktree prune --expires
Date: Tue, 30 Mar 2021 14:10:21 -0700 [thread overview]
Message-ID: <xmqqim58cpqa.fsf@gitster.g> (raw)
In-Reply-To: <011901d72596$e5ed8670$b1c89350$@nexbridge.com> (Randall S. Becker's message of "Tue, 30 Mar 2021 15:00:00 -0400")
"Randall S. Becker" <rsbecker@nexbridge.com> writes:
> This is pretty much just a quibble, but the command parser for worktree
> prune --expires should really report when a timestamp is invalid. For
> example:
>
> worktree prune --expires A:30 actually
Assuming that you had "git" in front, and spelled "--expire" without
the extra 's':
$ git worktree prune --expire no.such.date
fatal: malformed expiration date 'no.such.date'
So apparently, "A:30" is taken as a expiration date that is not
malformed.
$ git rev-parse --since=A:30 --until=now
--max-age=1617138312
--min-age=1617138312
Appears to show that A:30 is interpreted as the same as 'now', but
thta is an unlucky coincidence of the day.
What happens in this case is that "A:" is discarded as cruft (just
like dots are discarded in "git log --since=8.days.ago"), and only
the "30" takes effect of filling an unspecified "date of the month"
[*1*]. And then the remainder is taken from the wallclock time, and
that is how the above "rev-parse" shows the same for A:30 and now,
as it is the 30th of the month for me right now.
$ git rev-parse --since=A:31 --until=now
--max-age=1617224881
--min-age=1617138481
gives me the same time tomorrow (for the same reason that today's
30th for me).
[Footnote]
*1* In A:30, there is no "date of month", "month", "year",
etc. specified, so we start from all unspecified, take the first
number that is discovered (i.e. 30) and fill "date of the month"
with it.
next prev parent reply other threads:[~2021-03-30 21:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 19:00 [Bug] worktree prune --expires Randall S. Becker
2021-03-30 21:10 ` Junio C Hamano [this message]
2021-03-30 21:22 ` Randall S. Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqim58cpqa.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=rsbecker@nexbridge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).