From: Junio C Hamano <gitster@pobox.com>
To: Matheus Tavares Bernardino <matheus.bernardino@usp.br>
Cc: git <git@vger.kernel.org>
Subject: Re: Is git-am expected to honor core.sharedRepository?
Date: Wed, 02 Dec 2020 14:06:04 -0800 [thread overview]
Message-ID: <xmqqim9jn9rn.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <CAHd-oW4yHSTYr0Gwn60tu2c7VY=PJbSbg23Z5Bd_11Do-+juGA@mail.gmail.com> (Matheus Tavares Bernardino's message of "Tue, 1 Dec 2020 12:23:55 -0300")
Matheus Tavares Bernardino <matheus.bernardino@usp.br> writes:
> (For some background, I stumbled across this while considering using
> safe_create_leading_directories() for a parallel-checkout patch. But
> then I noticed it adjusts the directories' permissions based on the
> setting and I was worried whether it could be user for checkout.)
Forgot to respond to this part, but you are correct.
Anything that tries to replace what is in entry.c must not trigger
adjust_shared_perm() on files and directories in the working tree,
and it is a no-no to call safe_create_leading_directories().
next prev parent reply other threads:[~2020-12-02 22:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 15:23 Is git-am expected to honor core.sharedRepository? Matheus Tavares Bernardino
2020-12-01 17:58 ` Junio C Hamano
2020-12-01 23:45 ` [PATCH] apply: don't use core.sharedRepository to create working tree files Matheus Tavares
2020-12-02 0:21 ` Junio C Hamano
2020-12-19 17:51 ` Adam Dinwoodie
2020-12-19 18:12 ` Junio C Hamano
2020-12-19 18:59 ` Adam Dinwoodie
2020-12-19 18:32 ` Achim Gratz
2020-12-19 19:57 ` Adam Dinwoodie
2020-12-19 21:01 ` Achim Gratz
2020-12-22 22:24 ` Adam Dinwoodie
2020-12-22 22:49 ` Matheus Tavares Bernardino
2020-12-23 11:44 ` [PATCH] t4129: fix setfacl-related permissions failure Adam Dinwoodie
2021-01-09 15:06 ` Matheus Tavares Bernardino
2021-01-09 22:43 ` Junio C Hamano
2020-12-02 22:06 ` Junio C Hamano [this message]
2020-12-03 1:44 ` Is git-am expected to honor core.sharedRepository? Matheus Tavares Bernardino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqim9jn9rn.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=matheus.bernardino@usp.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).