git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: Denton Liu <liu.denton@gmail.com>,
	Git Mailing List <git@vger.kernel.org>,
	Robert Simpson <no-reply@MailScreen.com>,
	Eric Sunshine <sunshine@sunshineco.com>
Subject: Re: [PATCH v2] switch: fix errors and comments related to -c and -C
Date: Thu, 30 Apr 2020 13:45:06 -0700	[thread overview]
Message-ID: <xmqqimhgr9d9.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200430162151.GB30682@syl.local> (Taylor Blau's message of "Thu, 30 Apr 2020 10:21:51 -0600")

Taylor Blau <me@ttaylorr.com> writes:

> Nicely done. This revision looks great to me, thanks.
>
>   Reviewed-by: Taylor Blau <me@ttaylorr.com>

I'd squeeze this into a single line, though.

> -			die(_("missing branch name; try -b"));
> +			die(_("missing branch name; try -%c"),
> +					cb_option);

Will queue with a local fix-up for the above.

Thanks.

      reply	other threads:[~2020-04-30 20:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-28 23:12 Git error message suggests an invalid switch Robert Simpson
2020-04-29  9:00 ` [PATCH] switch: fix errors and comments related to -c and -C Denton Liu
2020-04-29 16:09   ` Taylor Blau
2020-04-29 16:31     ` Eric Sunshine
2020-04-29 16:35   ` Junio C Hamano
2020-04-30 11:54   ` [PATCH v2] " Denton Liu
2020-04-30 16:21     ` Taylor Blau
2020-04-30 20:45       ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqimhgr9d9.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=liu.denton@gmail.com \
    --cc=me@ttaylorr.com \
    --cc=no-reply@MailScreen.com \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).