From: Junio C Hamano <gitster@pobox.com>
To: "Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, peff@peff.net, me@ttaylorr.com,
jonathantanmy@google.com, jrnieder@gmail.com,
Derrick Stolee <dstolee@microsoft.com>
Subject: Re: [PATCH 1/2] partial-clone: demonstrate bugs in partial fetch
Date: Wed, 19 Feb 2020 12:52:14 -0800 [thread overview]
Message-ID: <xmqqimk2e1vl.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <dbc1bdcae16f8b9941add514264b0fe04cda48c0.1582129312.git.gitgitgadget@gmail.com> (Derrick Stolee via GitGitGadget's message of "Wed, 19 Feb 2020 16:21:51 +0000")
"Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com> writes:
> diff --git a/t/t5616-partial-clone.sh b/t/t5616-partial-clone.sh
> index fea56cda6d3..ed2ef45c37a 100755
> --- a/t/t5616-partial-clone.sh
> +++ b/t/t5616-partial-clone.sh
> @@ -374,6 +374,32 @@ test_expect_success 'fetch lazy-fetches only to resolve deltas, protocol v2' '
> grep "want $(cat hash)" trace
> '
>
> +test_expect_failure 'verify fetch succeeds when asking for new tags' '
> + git clone --filter=blob:none "file://$(pwd)/srv.bare" tag-test &&
> + for i in I J K
> + do
> + test_commit -C src $i &&
> + git -C src branch $i
> + done &&
> + git -C srv.bare fetch --tags origin +refs/heads/*:refs/heads/* &&
> + git -C tag-test fetch --tags origin
> +'
Is this about an ultra-recent regresssion? When applied directly on
top of v2.25.0, this one seems to pass already without any change.
> +test_expect_failure 'verify fetch downloads only one pack when updating refs' '
> + git clone --filter=blob:none "file://$(pwd)/srv.bare" pack-test &&
> + ls pack-test/.git/objects/pack/*pack >pack-list &&
> + test_line_count = 2 pack-list &&
> + for i in A B C
> + do
> + test_commit -C src $i &&
> + git -C src branch $i
> + done &&
> + git -C srv.bare fetch origin +refs/heads/*:refs/heads/* &&
> + git -C pack-test fetch origin &&
> + ls pack-test/.git/objects/pack/*pack >pack-list &&
> + test_line_count = 3 pack-list
> +'
> +
> . "$TEST_DIRECTORY"/lib-httpd.sh
> start_httpd
next prev parent reply other threads:[~2020-02-19 20:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-19 16:21 [PATCH 0/2] Document two partial clone bugs, fix one Derrick Stolee via GitGitGadget
2020-02-19 16:21 ` [PATCH 1/2] partial-clone: demonstrate bugs in partial fetch Derrick Stolee via GitGitGadget
2020-02-19 18:38 ` Eric Sunshine
2020-02-19 20:42 ` Derrick Stolee
2020-02-19 20:52 ` Junio C Hamano [this message]
2020-02-19 20:59 ` Eric Sunshine
2020-02-19 21:17 ` Junio C Hamano
2020-02-19 21:20 ` Derrick Stolee
2020-02-19 16:21 ` [PATCH 2/2] partial-clone: avoid fetching when looking for objects Derrick Stolee via GitGitGadget
2020-02-19 18:10 ` Jonathan Tan
2020-02-19 21:10 ` [PATCH 0/2] Document two partial clone bugs, fix one Derrick Stolee
2020-02-21 21:47 ` [PATCH v2 " Derrick Stolee via GitGitGadget
2020-02-21 21:47 ` [PATCH v2 1/2] partial-clone: demonstrate bugs in partial fetch Derrick Stolee via GitGitGadget
2020-02-21 21:47 ` [PATCH v2 2/2] partial-clone: avoid fetching when looking for objects Derrick Stolee via GitGitGadget
2020-02-22 17:25 ` [PATCH v2 0/2] Document two partial clone bugs, fix one Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqimk2e1vl.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=dstolee@microsoft.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=jonathantanmy@google.com \
--cc=jrnieder@gmail.com \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).