git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Denton Liu <liu.denton@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] pthread.h: manually align parameter lists
Date: Fri, 11 Oct 2019 14:59:55 +0900	[thread overview]
Message-ID: <xmqqimovhles.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <b3d6dfe44a76c4f3bf00eb901c1844b12300c66e.1570736137.git.liu.denton@gmail.com> (Denton Liu's message of "Thu, 10 Oct 2019 12:37:04 -0700")

Denton Liu <liu.denton@gmail.com> writes:

> In previous patches, extern was mechanically removed from function
> declarations without care to formatting, causing parameter lists to be
> misaligned. Manually format changed sections such that the parameter
> lists are realigned.
>
> Viewing this patch with 'git diff -w' should produce no output.
>
> Signed-off-by: Denton Liu <liu.denton@gmail.com>
> ---
> I missed a step in 'dl/compat-cleanup'. This patch can be applied on the
> tip of that branch.
>
>  compat/win32/pthread.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/compat/win32/pthread.h b/compat/win32/pthread.h
> index f1cfe73de9..737983d00b 100644
> --- a/compat/win32/pthread.h
> +++ b/compat/win32/pthread.h
> @@ -51,7 +51,7 @@ typedef struct {
>  } pthread_t;
>  
>  int pthread_create(pthread_t *thread, const void *unused,
> -			  void *(*start_routine)(void*), void *arg);
> +		   void *(*start_routine)(void*), void *arg);

Yup, I missed that too.  Thanks for a clean-up.

>  
>  /*
>   * To avoid the need of copying a struct, we use small macro wrapper to pass

      reply	other threads:[~2019-10-11  6:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-10 19:37 [PATCH] pthread.h: manually align parameter lists Denton Liu
2019-10-11  5:59 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqimovhles.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=liu.denton@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).