From: Junio C Hamano <gitster@pobox.com>
To: Jakub Narebski <jnareb@gmail.com>
Cc: Shin Kojima <shin@kojima.org>, git@vger.kernel.org
Subject: Re: [PATCH] gitweb: Measure offsets against UTF-8 flagged string
Date: Fri, 04 May 2018 11:38:17 +0900 [thread overview]
Message-ID: <xmqqin84taau.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <86k1skzzc4.fsf@gmail.com> (Jakub Narebski's message of "Thu, 03 May 2018 14:40:59 +0200")
Jakub Narebski <jnareb@gmail.com> writes:
> I think the problem is not with aligning, otherwise we would simply get
> bad aling, and not visible corruption. The ACTUAL PROBLEM is most
> probably because of concatenating strings marked as UTF-8 and strings
> not marked as UTF-8. Strange things happen then in Perl, unfortunetaly.
Sounds quite right---the patch needs to be retitled, if the bug is
not about "measuring offset", which I think is what fooled me when I
sent my response.
prev parent reply other threads:[~2018-05-04 2:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-01 6:40 [PATCH] gitweb: Measure offsets against UTF-8 flagged string Shin Kojima
2018-05-02 8:01 ` Junio C Hamano
2018-05-02 11:47 ` Shin Kojima
2018-05-03 12:40 ` Jakub Narebski
2018-05-03 15:16 ` Shin Kojima
2018-05-04 2:38 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqin84taau.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=shin@kojima.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).