From: Junio C Hamano <gitster@pobox.com>
To: Kristofer Karlsson <krka@spotify.com>
Cc: Kristofer Karlsson via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH 2/2] commit-graph: propagate topo_levels slab to all chain layers
Date: Tue, 07 Jul 2026 13:13:57 -0700 [thread overview]
Message-ID: <xmqqjyr61rsq.fsf@gitster.g> (raw)
In-Reply-To: <CAL71e4NXPAitqQtCnwLCyXvigD5KjOCSj5em+3v4WSUaYQKHRg@mail.gmail.com> (Kristofer Karlsson's message of "Tue, 7 Jul 2026 19:42:52 +0200")
Kristofer Karlsson <krka@spotify.com> writes:
> On Tue, 7 Jul 2026 at 19:00, Junio C Hamano <gitster@pobox.com> wrote:
>> >
>> > Fix a regression introduced in 199d452758 (commit-graph: fix
>> > "filling in" topological levels, 2025-04-07) where the loop
>>
>> I guess the same comment from [1/2] applies. We might be chasing
>> ghosts here. Is that elusive commit a total hallucination?
>
> Oops! The commit exists but the date there is indeed wrong.
> Will fix (or just remove it, I am starting to regret trying to make
> the commit reference too detailed in the first place).
Heh, "git show -s --pretty=reference" would give the right amount of
information without giving leeway to users to decide what level of
detail they want ;-)
Thanks. Will mark the topic as "Expecting a reroll.".
next prev parent reply other threads:[~2026-07-07 20:14 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-07 9:59 [PATCH 0/2] commit-graph: fix topo_levels slab propagation regression Kristofer Karlsson via GitGitGadget
2026-07-07 9:59 ` [PATCH 1/2] commit-graph: add trace2 instrumentation for generation DFS Kristofer Karlsson via GitGitGadget
2026-07-07 13:46 ` Taylor Blau
2026-07-07 14:08 ` Kristofer Karlsson
2026-07-10 22:09 ` Taylor Blau
2026-07-10 22:28 ` Junio C Hamano
2026-07-10 22:56 ` Taylor Blau
2026-07-11 21:18 ` Junio C Hamano
2026-07-13 19:55 ` Kristofer Karlsson
2026-07-13 20:42 ` Junio C Hamano
2026-07-13 22:17 ` Kristofer Karlsson
2026-07-07 16:55 ` Junio C Hamano
2026-07-07 17:39 ` Kristofer Karlsson
2026-07-07 9:59 ` [PATCH 2/2] commit-graph: propagate topo_levels slab to all chain layers Kristofer Karlsson via GitGitGadget
2026-07-07 13:49 ` Taylor Blau
2026-07-07 14:02 ` Kristofer Karlsson
2026-07-07 14:57 ` Kristofer Karlsson
2026-07-10 22:14 ` Taylor Blau
2026-07-13 6:16 ` Patrick Steinhardt
2026-07-14 3:31 ` Taylor Blau
2026-07-07 17:00 ` Junio C Hamano
2026-07-07 17:42 ` Kristofer Karlsson
2026-07-07 20:13 ` Junio C Hamano [this message]
2026-07-09 13:43 ` Patrick Steinhardt
2026-07-09 15:02 ` [PATCH v2 0/2] commit-graph: fix topo_levels slab propagation regression Kristofer Karlsson via GitGitGadget
2026-07-09 15:03 ` [PATCH v2 1/2] commit-graph: add trace2 instrumentation for generation DFS Kristofer Karlsson via GitGitGadget
2026-07-09 15:03 ` [PATCH v2 2/2] commit-graph: propagate topo_levels slab to all chain layers Kristofer Karlsson via GitGitGadget
2026-07-10 22:15 ` [PATCH v2 0/2] commit-graph: fix topo_levels slab propagation regression Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqjyr61rsq.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=krka@spotify.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox