Re: [PATCH 00/13] coverity: fix leaks and error paths

[Junio C Hamano <gitster@pobox.com>]

"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
writes:

> I wanted to whittle down the many issues reported by Coverity in the Git for
> Windows project. Turns out: The vast majority of the issues are false
> positives. Most of the remaining issues are in core Git proper.

I read through the series and did not see anything jumping at me as
wrong.  Looking good.  Will queue.

Thanks.

>
> This effort was forced on pause while Coverity was down from May 16
> [https://web.archive.org/web/20260516152422/https://scan.coverity.com/] to
> June 22
> [https://web.archive.org/web/20260622182153/https://scan.coverity.com/]).
>
> Here is a first batch of fixes for those issues.
>
> Johannes Schindelin (13):
>   load_one_loose_object_map(): fix resource leak
>   loose: avoid closing invalid fd on error path
>   download_https_uri_to_file(): do not leak fd upon failure
>   run-command: avoid close(-1) in start_command() error paths
>   run_diff_files: avoid memory leak
>   line-log: avoid redundant copy that leaks in process_ranges
>   dir: free allocations on parse-error paths in read_one_dir()
>   submodule: fix cwd leak in get_superproject_working_tree()
>   worktree: fix resource leaks when branch creation fails
>   imap-send: avoid leaking the IMAP upload buffer
>   reftable/table: release filter on error path
>   fsmonitor: plug token-data leak on early daemon-startup failures
>   mingw: make exit_process() own the process handle on all paths
>
>  builtin/fsmonitor--daemon.c |  2 ++
>  builtin/worktree.c          |  7 +++++--
>  bundle-uri.c                |  2 +-
>  compat/mingw.c              |  4 +---
>  compat/win32/exit-process.h |  1 +
>  diff-lib.c                  |  3 ++-
>  dir.c                       |  9 +++++++--
>  imap-send.c                 |  1 +
>  line-log.c                  |  3 +--
>  loose.c                     | 11 ++++++-----
>  reftable/table.c            |  4 ++++
>  run-command.c               |  6 +++---
>  submodule.c                 |  8 ++++++--
>  13 files changed, 40 insertions(+), 21 deletions(-)
>
>
> base-commit: e9019fcafe0040228b8631c30f97ae1adb61bcdc
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-2163%2Fdscho%2Fcoverity-fixes-leaks-and-error-paths-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-2163/dscho/coverity-fixes-leaks-and-error-paths-v1
> Pull-Request: https://github.com/gitgitgadget/git/pull/2163