git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Cc: "Kiril Ivanov via GitGitGadget" <gitgitgadget@gmail.com>,
	 Kiril Ivanov <ivanovkirilg@gmail.com>
Subject: Re: [PATCH 0/3] git-prompt: add quiet upstream indicator option
Date: Sat, 15 Nov 2025 12:07:05 -0800	[thread overview]
Message-ID: <xmqqjyzrdpqu.fsf@gitster.g> (raw)
In-Reply-To: <pull.2101.git.git.1763232863.gitgitgadget@gmail.com> (Kiril Ivanov via GitGitGadget's message of "Sat, 15 Nov 2025 18:54:20 +0000")

"Kiril Ivanov via GitGitGadget" <gitgitgadget@gmail.com> writes:

> Kiril Ivanov (3):
>   t9903: shorten setup using test_commit
>   t9903: add upstream indicator tests
>   git-prompt: add quiet upstream indicator option
>
>  contrib/completion/git-prompt.sh | 14 ++++--
>  t/t9903-bash-prompt.sh           | 86 ++++++++++++++++++++++++++------


Not about the patch, but a slightly related tangent, but I wonder if
we want to update t/t9903-bash-prompt.sh script so that it starts
with "#!/bin/bash" not "#!/bin/sh" (this is a reaction to seeing
some bash-isms in these patches.  No complaints here, as the test
script is all about the command line prompt feature to be used with
bash and nothing else).



>  2 files changed, 80 insertions(+), 20 deletions(-)
>
>
> base-commit: fd372d9b1a69a01a676398882bbe3840bf51fe72
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2101%2Fivanovkirilg%2Fquiet-option-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2101/ivanovkirilg/quiet-option-v1
> Pull-Request: https://github.com/git/git/pull/2101

  parent reply	other threads:[~2025-11-15 20:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-15 18:54 [PATCH 0/3] git-prompt: add quiet upstream indicator option Kiril Ivanov via GitGitGadget
2025-11-15 18:54 ` [PATCH 1/3] t9903: shorten setup using test_commit Kiril Ivanov via GitGitGadget
2025-11-15 18:54 ` [PATCH 2/3] t9903: add upstream indicator tests Kiril Ivanov via GitGitGadget
2025-11-15 18:54 ` [PATCH 3/3] git-prompt: add quiet upstream indicator option Kiril Ivanov via GitGitGadget
2025-11-20 16:01   ` D. Ben Knoble
2025-11-20 18:05     ` Eric Sunshine
2025-11-20 18:18       ` D. Ben Knoble
2025-11-15 20:07 ` Junio C Hamano [this message]
2025-11-16 12:05   ` [PATCH 0/3] " Kiril Ivanov
2025-11-16 16:55     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqjyzrdpqu.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=ivanovkirilg@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).