From: Junio C Hamano <gitster@pobox.com>
To: opensource@gregoirege.is
Cc: git@vger.kernel.org
Subject: Re: [PATCH] diff-no-index: fix stdin path in subdirectory
Date: Fri, 08 Aug 2025 09:09:25 -0700 [thread overview]
Message-ID: <xmqqjz3diymi.fsf@gitster.g> (raw)
In-Reply-To: <CCF4B0E0-980D-472A-8689-7615FFFE0198@gregoirege.is> (opensource@gregoirege.is's message of "Fri, 8 Aug 2025 20:25:36 +0900")
opensource@gregoirege.is writes:
> Junio C Hamano <gitster@pobox.com> wrote:
>
>> ... there fundamentally is something wrong here.
>
> Thank you for the thorough response and for explaining the
> reasoning / implementation of the more correct patch.
>
>> Would something more direct like the attached patch work?
>
> I am not familiar with the inner workings of Git at all, but I
> cannot think of any problem with this approach. This works for me!
Ah, what I meant was that I did not test the patch, so I did not
know if it solves the problem you observed in your environment and
with your development tools, hence I was asking you to apply it and
test, like you did when you originally noticed the problem ;-)
Thanks.
next prev parent reply other threads:[~2025-08-08 16:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-07 15:06 [PATCH] diff-no-index: fix stdin path in subdirectory Gregoire Geis
2025-08-07 18:36 ` Junio C Hamano
2025-08-08 11:25 ` opensource
2025-08-08 16:09 ` Junio C Hamano [this message]
2025-08-09 2:12 ` opensource
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqjz3diymi.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=opensource@gregoirege.is \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).