public inbox for git@vger.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Patrick Steinhardt <ps@pks.im>,
	 git@vger.kernel.org,
	 Kristoffer Haugsbakk <code@khaugsbakk.name>
Subject: Re: [PATCH 2/2] builtin/mv: convert assert(3p) into `BUG()`
Date: Fri, 02 May 2025 09:53:03 -0700	[thread overview]
Message-ID: <xmqqjz6zuf80.fsf@gitster.g> (raw)
In-Reply-To: <38cc3249-3de2-5ed0-7ca8-bad6d4a5bea8@gmx.de> (Johannes Schindelin's message of "Fri, 2 May 2025 11:44:36 +0200 (CEST)")

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> The fact of the matter is that the Visual C-built CI (first the Azure
> Pipeline, then GitHub Actions) have built the artifacts in release mode
> since forever. And the Meson addition simply made a mistake by _not
> specifying_ release mode (and hence defaulting to debug mode).

OK, so this is needed for _different_ reason; it is no longer about
working around a stuck CI due to misguided test.  The artifacts
should be built in a particular way to be consistent with the other
build pipelines (presumably they are used in production later, or
something?).

If explained that way in the updated log message, I would be very
happy to take the patch and merge it down, even fast-tracking down
to 'maint'.

Thanks.

      reply	other threads:[~2025-05-02 16:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-30 12:44 [PATCH 0/2] builtin/mv: bail out when trying to move child and its parent Patrick Steinhardt
2025-04-30 12:44 ` [PATCH 1/2] " Patrick Steinhardt
2025-04-30 22:21   ` Junio C Hamano
2025-05-02  8:07     ` Patrick Steinhardt
2025-04-30 12:44 ` [PATCH 2/2] builtin/mv: convert assert(3p) into `BUG()` Patrick Steinhardt
2025-04-30 18:45   ` Junio C Hamano
2025-04-30 23:10     ` Junio C Hamano
2025-05-02  8:06       ` Patrick Steinhardt
2025-05-02  9:44         ` Johannes Schindelin
2025-05-02 16:53           ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqjz6zuf80.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=code@khaugsbakk.name \
    --cc=git@vger.kernel.org \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox