From: Junio C Hamano <gitster@pobox.com>
To: "René Scharfe" <l.s.r@web.de>
Cc: Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org,
Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH] t-reftable-basics: allow for `malloc` to be `#define`d
Date: Wed, 08 Jan 2025 09:41:32 -0800 [thread overview]
Message-ID: <xmqqjzb5mcdv.fsf@gitster.g> (raw)
In-Reply-To: <e842ea8c-4ead-49d0-a48b-0d5f8c4e7c0c@web.de> ("René Scharfe"'s message of "Wed, 8 Jan 2025 17:36:34 +0100")
René Scharfe <l.s.r@web.de> writes:
>> It is actually unnecessary to use those function pointers to
>> `malloc`/`realloc`/`free`, though: The `reftable` code goes out of its
>> way to fall back to the initial allocator when passing `NULL` parameters
>> instead. So let's do that instead of causing heap corruptions.
>
> Ugh. That makes a lot of sense. Sorry for the trouble! :-/
Thanks for a quick Ack.
next prev parent reply other threads:[~2025-01-08 17:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-08 16:00 [PATCH] t-reftable-basics: allow for `malloc` to be `#define`d Johannes Schindelin via GitGitGadget
2025-01-08 16:36 ` René Scharfe
2025-01-08 17:41 ` Junio C Hamano [this message]
2025-01-08 17:14 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqjzb5mcdv.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=johannes.schindelin@gmx.de \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).