From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout-b4-smtp.messagingengine.com (fout-b4-smtp.messagingengine.com [202.12.124.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 495231FF1A5 for ; Wed, 8 Jan 2025 17:41:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.147 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736358097; cv=none; b=jDLAsPaeMhP5eEX2sNZYJd9wgsdXX4Ohnoe2iYYXol3Ac7JGQAj1JDKXksa146S/884wT4+YPpLXCCvipAqcYkMGOGMlZ4NnvzzcQ8JtTknzbi+Rqls68BUeDuAd0XsKU3Kgr6I4SGiG/L02uaWCA0aEIaCt06pHtdRBeMIsJtg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736358097; c=relaxed/simple; bh=O9Sxy5NeJt9C/JJle1fvb3dYjfbPdjvC44mgNCczzQw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=Wsae7pKe++YBdb9HZixA2Fi6igZmf3jv10MpP1+3otZ6frHgeIy8vxF7wIeF+bPgDpVCw2OYQj5fF1kAqaVqaq2VVC7ki9TMNl8MzavA2TaL9m7hZGcWHVDQ06/iRmAYAkqrTEtL4mrp87YaTk/5UFQg9g3Dmby8MUp7GPqOqJ4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=pobox.com; spf=pass smtp.mailfrom=pobox.com; dkim=pass (2048-bit key) header.d=pobox.com header.i=@pobox.com header.b=4YYGM0rc; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=vl8eAU0k; arc=none smtp.client-ip=202.12.124.147 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=pobox.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pobox.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=pobox.com header.i=@pobox.com header.b="4YYGM0rc"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="vl8eAU0k" Received: from phl-compute-03.internal (phl-compute-03.phl.internal [10.202.2.43]) by mailfout.stl.internal (Postfix) with ESMTP id 35CDA11400A8; Wed, 8 Jan 2025 12:41:34 -0500 (EST) Received: from phl-frontend-02 ([10.202.2.161]) by phl-compute-03.internal (MEProxy); Wed, 08 Jan 2025 12:41:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pobox.com; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1736358094; x=1736444494; bh=yT21XRFBgDKCO0QuowltFS6Y4Mr9jx2l0J9Qx5o4NcQ=; b= 4YYGM0rcVTZSgGGRkkageLQzBjpSPCpnkap9HP3IINF5baEneO8SjSlageCcVhCP D50ABKcYO4wFgNEG0Dwbq9LRBULxKeS9UP6KNA2y9UYMvO2WoiLpPbX7wEz/Xfo3 JF4bKmxon3CZkqmXGkmKgrCQACBApGZpU29E99vK5eNpyFl33IWrfkeyIGxs5Qx4 zFhnKIERbTyEh8l6vQHDn7TGWLQ0clxaCUvfeNLF5vZ8VXD4tWuhxRQa0Cro5iT3 4xkDtqAAQrIBGZe6YDnELQ3B3GfjxwtTi3gAOpYZA+ElLcKx3xOPGhp6jAUrsXZY eiyTEjT1Ustf2FYfq9tO9g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1736358094; x= 1736444494; bh=yT21XRFBgDKCO0QuowltFS6Y4Mr9jx2l0J9Qx5o4NcQ=; b=v l8eAU0kmyPvjD/rVoL8DwmCc2+dJIYYLq54X5Nd9mbqSIvWVZ5q4lVigIhPLdTe/ eKooGyYXwA9opJIqVY4v/XEUdYbAtPwloR6YXvtpwlRIon5nSAlGunCD3Ulhzna0 1TFKK+FX8yiRzqw+/S9ZAlyMj3i+h/GA/GT/gCqtsPl6agcmwqvsYf8ysqIINC/V sAKxozFw9Ex+RuRFVI6YuhDeb6PqsCWQI9s9cjudHTUpg4Goxj5pPkxar77oIYqU u1tBNopF6Du2LVQf0zzANp/1qKhEKou2iWFAf+ZQ0sqBUNIdFaURVtIYkBO5N6V8 2+IrggB+opCNqcqlbJyQg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrudeggedguddtvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhvfevufgjfhffkfgfgggtgfesthekredttder jeenucfhrhhomheplfhunhhiohcuvecujfgrmhgrnhhouceoghhithhsthgvrhesphhosg hogidrtghomheqnecuggftrfgrthhtvghrnheptdffvdetgedvtdekteefveeuveelgfek feehiefgheevhedvkeehleevveeftdehnecuvehluhhsthgvrhfuihiivgeptdenucfrrg hrrghmpehmrghilhhfrhhomhepghhithhsthgvrhesphhosghogidrtghomhdpnhgspghr tghpthhtohephedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtoheplhdrshdrrhesfi gvsgdruggvpdhrtghpthhtohepghhithhgihhtghgrughgvghtsehgmhgrihhlrdgtohhm pdhrtghpthhtohepghhithesvhhgvghrrdhkvghrnhgvlhdrohhrghdprhgtphhtthhope hjohhhrghnnhgvshdrshgthhhinhguvghlihhnsehgmhigrdguvgdprhgtphhtthhopehg ihhtshhtvghrsehpohgsohigrdgtohhm X-ME-Proxy: Feedback-ID: if26b431b:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 8 Jan 2025 12:41:33 -0500 (EST) From: Junio C Hamano To: =?utf-8?Q?Ren=C3=A9?= Scharfe Cc: Johannes Schindelin via GitGitGadget , git@vger.kernel.org, Johannes Schindelin Subject: Re: [PATCH] t-reftable-basics: allow for `malloc` to be `#define`d In-Reply-To: (=?utf-8?Q?=22R?= =?utf-8?Q?en=C3=A9?= Scharfe"'s message of "Wed, 8 Jan 2025 17:36:34 +0100") References: Date: Wed, 08 Jan 2025 09:41:32 -0800 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit René Scharfe writes: >> It is actually unnecessary to use those function pointers to >> `malloc`/`realloc`/`free`, though: The `reftable` code goes out of its >> way to fall back to the initial allocator when passing `NULL` parameters >> instead. So let's do that instead of causing heap corruptions. > > Ugh. That makes a lot of sense. Sorry for the trouble! :-/ Thanks for a quick Ack.