From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org, Christian Couder <chriscool@tuxfamily.org>
Subject: Re: [PATCH 1/2] refs: adapt `initial_transaction` flag to be unsigned
Date: Tue, 26 Nov 2024 17:22:26 +0900 [thread overview]
Message-ID: <xmqqjzcqxv3x.fsf@gitster.g> (raw)
In-Reply-To: <20241125-pks-refs-migration-optimization-followup-v1-1-0e1b4a2af384@pks.im> (Patrick Steinhardt's message of "Mon, 25 Nov 2024 08:34:42 +0100")
Patrick Steinhardt <ps@pks.im> writes:
> The `initial_transaction` flag is tracked as a signed integer, but we
> typically pass around flags via unsigned integers. Adapt the type
> accordingly.
It would not matter while the information in the variable is 1 bit
and the check is "is the whole variable 0?", which is what the
current code does on this parameter. But when we'd start using the
parameter as a flag word to stuff more bits, this starts to matter.
Good future-proofing. Thanks.
next prev parent reply other threads:[~2024-11-26 8:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-25 7:34 [PATCH 0/2] refs: stylistic improvements to ref migration optimization Patrick Steinhardt
2024-11-25 7:34 ` [PATCH 1/2] refs: adapt `initial_transaction` flag to be unsigned Patrick Steinhardt
2024-11-26 8:22 ` Junio C Hamano [this message]
2024-11-25 7:34 ` [PATCH 2/2] reftable: rename scratch buffer Patrick Steinhardt
2024-11-25 9:35 ` [PATCH 0/2] refs: stylistic improvements to ref migration optimization Christian Couder
2024-11-25 23:39 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqjzcqxv3x.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).